Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Block all unencrypted requests don't work #10150

Closed

Description

@heubergen

STR:

  1. Install the latest Webextensions Version of HTTPS Everywhere for Firefox
  2. Activate the option Block all unencrypted requests
  3. Open http://http.badssl.com/

Expected result:
Site should be blocked

Actual result:
Site ist loaded fine and the option Block all unencrypted requests is deactivated again

Activity

  1. jeremyn commented on Jun 4, 2017

    @jeremyn
    Contributor

    Thanks for the report. I can't reproduce this but I'm getting a different problem with the WebExtensions add-on, Block all unencrypted requests enabled, when visiting http://http.badssl.com/ . First it loads https, gets a 301, and then it tries to load plain http, gets a 200, and then it repeats that several times until it gives up. Nothing disables Block all unencrypted requests. It definitely should not be trying to load plain http.

    @heubergen Can you confirm this happens in a new profile (about:profiles)? If so, can you try loading the page with Firefox developer tools (F12) open, looking at the Network tab, and give more information about what's happening there? You may need to disable multiprocess/"Electrolysis" (set browser.tabs.remote.autostart and browser.tabs.remote.autostart.2 in about:config to false) to see the initial load behavior due to a Firefox bug I can't find right now.

    @Hainish This seems serious so I'm pinging you in addition to adding the webextensions-firefox label.

  2. heubergen commented on Jun 4, 2017

    @heubergen
    Author

    I think the issue is more that when I activate the option Block all unencrypted requests, close the popup and reopen it again, the option is deactivated again...

    I used https-everywhere-2017.6.1.1337-eff.xpi from this site https://www.eff.org/files/https-everywhere-test/index.html

    I did a test with a complety fresh profile and deactivated e10s: (hope I catch all the important information)
    https-everywhere

  3. jeremyn commented on Jun 4, 2017

    @jeremyn
    Contributor

    I'm using Firefox 53.0.3 (stable), not 55 (nightly). Does this happen for you in 53?

  4. heubergen commented on Jun 4, 2017

    @heubergen
    Author

    With FF53 it seems to work for me: (no e10s)
    https-everywhere-stable

    I could also vertify that it works with FF54 Beta.

  5. Hainish commented on Jun 5, 2017

    @Hainish
    Member

    The WebExtensions version will not be deployed to Firefox < 52. In your original test, which version were you using?

  6. gloomy-ghost commented on Jun 6, 2017

    @gloomy-ghost
    Collaborator

    I can't reproduce this on Firefox 54.0b13 and 55.0a1 (20170605).

    @heubergen: It would be great if you could provide some debugging logs. Can you try the following steps and post the outputs?

    1. Open about:debugging, turn on "Enable add-on debugging"
    2. Find HTTPS Everywhere and click the "Debug" button. Allow connection to open a debugging window
    3. Click "Console", type DEFAULT_LOG_LEVEL=1, and then try to reproduce the issue.
  7. heubergen commented on Jun 6, 2017

    @heubergen
    Author

    Here we are:
    https-everywhere-1

    This time after I started the debug mode and clicked on the icon the popup was empty:
    https-everywhere-2
    after try one more time the popup (seems) works again.

  8. Hainish commented on Jun 6, 2017

    @Hainish
    Member

    @heubergen it is possible that other extensions are interfering with the functionality of HTTPS Everywhere. The Error: runtime.sendMessage's extensionId argument is invalid leads me to believe this may be the case.

    Is there a particular other extension which is installed whenever you encounter the issue?

  9. heubergen commented on Jun 6, 2017

    @heubergen
    Author

    @Hainish Just tested again with a fresh profile, sorry for that! Here the result:
    https-everywhere-3

  10. Hainish commented on Jun 6, 2017

    @Hainish
    Member

    I can reproduce this reliably in 55.0a1 (64-bit, Linux). Still not sure what the underlying problem is, though. This may be an issue with the Nightly channel. Google comes up with little relevant results. I'll try to find a Firefox dev to look at this.

  11. gripedthumbtacks commented on Aug 18, 2017

    @gripedthumbtacks

    i can also confirm this issue on chrome. very strange

  12. ivan-kolmychek commented on Aug 29, 2017

    @ivan-kolmychek

    I've encountered this issue both on Chromium (Version 60.0.3112.113 (Developer Build) (64-bit)) and on Firefox (55.0.2 (64-bit)), both on Arch Linux.

  13. gripedthumbtacks commented on Aug 29, 2017

    @gripedthumbtacks

    opened #12190 as well

  14. J0WI commented on Sep 7, 2017

    @J0WI
    Contributor

    I think this was a duplicate of #11943. Please reopen if the issue is still around with up to date versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions