Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Strange behaviour for 'Block all unencrypted requests' after browser restart #10478

Closed

Description

@Bisaloo

Steps to reproduce:

  1. Enable 'Block all unencrypted requests'. The extension icon should turn red and unencrypted requests are blocked
  2. Close Firefox.
  3. Open Firefox again.
  4. 'Block all unencrypted requests' is still checked (as it should be) but the extension icon is now blue and unencrypted requests are not actually blocked.

Related: #9958 (and possibly #10150).

HTTPS-Everywhere 2017.6.9.1337 and FF 54.0.

Activity

  1. Hainish commented on Aug 8, 2017

    @Hainish
    Member

    @Bisaloo this seems not to be happening in the Embedded WebExtensions version, see #11760. Can you test with this?

  2. Bisaloo commented on Aug 9, 2017

    @Bisaloo
    CollaboratorAuthor

    Nope, still doesn't work. I can reproduce on a fresh profile with Nightly (FF 57.0a1 (2017-08-03)) after building the xpi from 48d8d3e.

  3. Bisaloo commented on Aug 9, 2017

    @Bisaloo
    CollaboratorAuthor

    Maybe you got tricked by this new feature, introduced in FF 55.0?

    When entering a hostname (like pinterest.com) in the URL bar, Firefox resolves to the secure version of the site (https://www.pinterest.com) instead of the insecure version (http://www.pinterest.com) when possible

    https://www.mozilla.org/en-US/firefox/55.0/releasenotes/

  4. Hainish commented on Aug 10, 2017

    @Hainish
    Member

    @Bisaloo if you're testing on 57, then the extension shouldn't work at all!

  5. Bisaloo commented on Aug 10, 2017

    @Bisaloo
    CollaboratorAuthor

    Well, it looks like it does. Apparently, nightly still works with Legacy XUL add-ons if you turn the pref on. I simply have a big warning "Legacy".

    https://wiki.mozilla.org/Add-ons/Firefox57

  6. mgol commented on Aug 10, 2017

    @mgol

    @Bisaloo Enabling legacy add-ons on Nightly doesn't mean the add-on will work. Firefox devs work on the assumption only WebExtensions will be supported in Firefox 57+ so they're free to break any APIs legacy add-ons depend on. You may enable them but many of them will be broken anyway.

  7. Bisaloo commented on Aug 10, 2017

    @Bisaloo
    CollaboratorAuthor

    @Bisaloo Enabling legacy add-ons on Nightly doesn't mean the add-on will work. Firefox devs work on the assumption only WebExtensions will be supported in Firefox 57+ so they're free to break any APIs legacy add-ons depend on. You may enable them but many of them will be broken anyway.

    Okay, thanks for the heads up!

    For this particular issue, it doesn't change anything. Block all unencrypted requests was working before browser restart and it's not after restart.

  8. gripedthumbtacks commented on Aug 18, 2017

    @gripedthumbtacks

    i can also confirm this issue on chrome. very strange

  9. Bisaloo commented on Aug 24, 2017

    @Bisaloo
    CollaboratorAuthor

    @J0WI, could you also add the chrome tag since it apparently affects both browser?

  10. gripedthumbtacks commented on Aug 29, 2017

    @gripedthumbtacks

    SEE ALSO #12190

  11. Hainish commented on Aug 30, 2017

    @Hainish
    Member

    Fixed in #12268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions