Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Doesn't rewrite URLs with wildcard targets in Firefox (includes *.gfycat.com, *.github.io, *.imgur.com, *.shopify.com, *.media.tumblr.com) #11981

Closed

Description

@ADAMPOKE111

Accessing any image under the i.imgur.com subdomain through HTTP which is commonly hyperlinked on websites is not being redirected to the HTTPS variant for some odd reason despite the rule being present here: https://github.com/EFForg/https-everywhere/blob/a641125fc36c3a48a4cc4c33938fa369f397cfcc/src/chrome/content/rules/Imgur.xml

Activity

  1. Folant commented on Aug 18, 2017

    @Folant
    Contributor

    #11948 (comment)
    It seems to affect gfycat(e.g zippy.gfycat.com/giant.gfycat.com), media.tumblr.com(e.g 68.media.tumblr.com), shopify (e.g cdn.shopify.com), artlebedev.ru (img.artlebedev.ru) and maybe many [all?] other rules containing <target host="*.x.y" />

  2. ADAMPOKE111 commented on Aug 18, 2017

    @ADAMPOKE111
    Author

    Interesting, nothing was changed recently regarding the way URLs are interpretted as far as I can tell. I might have overlooked this or just not noticed the issue before. I can confirm it is happening on all my devices using HTTPS Everywhere.

  3. Folant commented on Aug 18, 2017

    @Folant
    Contributor

    or just not noticed the issue before

    Well, v5.2.21 seems to be working fine with these rules that contain wildcards, 2017.8.15/2017.8.17 is not [at least for some of us].

  4. ADAMPOKE111 commented on Aug 18, 2017

    @ADAMPOKE111
    Author

    I think I'm going to take a look into this tomorrow and do some experimentation to see if I can remedy it. If anyone else has anything they'd like to contribute, feel free to chip-in.

  5. Folant commented on Aug 18, 2017

    @Folant
    Contributor

    #11980 has basically the same issue due to Github-Pages.xml#L6 btw.

  6. jeremyn commented on Aug 19, 2017

    @jeremyn
    Contributor

    I agree with @Folant that wildcard targets aren't being rewritten, including both left wildcard targets such as http://www.imgur.com from Imgur.xml and right wildcard targets such as http://google.com from Google.xml.

    @Hainish Please take a look at this.

  7. changed the title [-]HTTP Requests to i.imgur.com are not being redirected to their HTTPS variant[/-] [+]Doesn't rewrite URLs with wildcard targets in Firefox[/+] on Aug 19, 2017
  8. changed the title [-]Doesn't rewrite URLs with wildcard targets in Firefox[/-] [+]Doesn't rewrite URLs with wildcard targets in Firefox (includes *.gfycat.com, *.github.io, *.imgur.com, *.shopify.com, *.media.tumblr.com)[/+] on Aug 19, 2017
  9. cschanaj commented on Aug 19, 2017

    @cschanaj
    Collaborator

    @Hainish would you make a release of the 5.2.21 (with the rulesets files from 2017.8.17) with automatic updates disabled (to be shipped with the tor-browser bundle as a temporary solution for tor-users/ advanced users)? For reasons being that

    • many targets using wildcards, especially the left wildcards are important domains
    • a large number of rulesets got re-activated after 5.2.21 is release, coverage improve greatly.

    P.S. IMHO this special release shouldn't be distribute as a update. thanks.

  10. Hainish commented on Aug 19, 2017

    @Hainish
    Member

    a69918f fixes this issue. I'll try to make a release tomorrow.

    As for a special release for Tor Browser, I've already instructed them how to make a release using 5.2.21 removing the update channel and checking out the latest rules. Tor Browser builds in HTTPS Everywhere as part of their release process from signed tags, so it's not a matter of me making a special release for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions