You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Doesn't rewrite URLs with wildcard targets in Firefox (includes *.gfycat.com, *.github.io, *.imgur.com, *.shopify.com, *.media.tumblr.com) #11981
#11948 (comment)
It seems to affect gfycat(e.g zippy.gfycat.com/giant.gfycat.com), media.tumblr.com(e.g 68.media.tumblr.com), shopify (e.g cdn.shopify.com), artlebedev.ru (img.artlebedev.ru) and maybe many [all?] other rules containing <target host="*.x.y" />
Interesting, nothing was changed recently regarding the way URLs are interpretted as far as I can tell. I might have overlooked this or just not noticed the issue before. I can confirm it is happening on all my devices using HTTPS Everywhere.
I think I'm going to take a look into this tomorrow and do some experimentation to see if I can remedy it. If anyone else has anything they'd like to contribute, feel free to chip-in.
changed the title [-]HTTP Requests to i.imgur.com are not being redirected to their HTTPS variant[/-][+]Doesn't rewrite URLs with wildcard targets in Firefox[/+]on Aug 19, 2017
changed the title [-]Doesn't rewrite URLs with wildcard targets in Firefox[/-][+]Doesn't rewrite URLs with wildcard targets in Firefox (includes *.gfycat.com, *.github.io, *.imgur.com, *.shopify.com, *.media.tumblr.com)[/+]on Aug 19, 2017
@Hainish would you make a release of the 5.2.21 (with the rulesets files from 2017.8.17) with automatic updates disabled (to be shipped with the tor-browser bundle as a temporary solution for tor-users/ advanced users)? For reasons being that
many targets using wildcards, especially the left wildcards are important domains
a large number of rulesets got re-activated after 5.2.21 is release, coverage improve greatly.
P.S. IMHO this special release shouldn't be distribute as a update. thanks.
a69918f fixes this issue. I'll try to make a release tomorrow.
As for a special release for Tor Browser, I've already instructed them how to make a release using 5.2.21 removing the update channel and checking out the latest rules. Tor Browser builds in HTTPS Everywhere as part of their release process from signed tags, so it's not a matter of me making a special release for them.
Activity
Folant commentedon Aug 18, 2017
#11948 (comment)
It seems to affect gfycat(e.g zippy.gfycat.com/giant.gfycat.com), media.tumblr.com(e.g 68.media.tumblr.com), shopify (e.g cdn.shopify.com), artlebedev.ru (img.artlebedev.ru) and maybe many [all?] other rules containing
<target host="*.x.y" />ADAMPOKE111 commentedon Aug 18, 2017
Interesting, nothing was changed recently regarding the way URLs are interpretted as far as I can tell. I might have overlooked this or just not noticed the issue before. I can confirm it is happening on all my devices using HTTPS Everywhere.
Folant commentedon Aug 18, 2017
Well, v5.2.21 seems to be working fine with these rules that contain wildcards, 2017.8.15/2017.8.17 is not [at least for some of us].
ADAMPOKE111 commentedon Aug 18, 2017
I think I'm going to take a look into this tomorrow and do some experimentation to see if I can remedy it. If anyone else has anything they'd like to contribute, feel free to chip-in.
Folant commentedon Aug 18, 2017
#11980 has basically the same issue due to Github-Pages.xml#L6 btw.
jeremyn commentedon Aug 19, 2017
I agree with @Folant that wildcard targets aren't being rewritten, including both left wildcard targets such as http://www.imgur.com from
Imgur.xmland right wildcard targets such as http://google.com fromGoogle.xml.@Hainish Please take a look at this.
[-]HTTP Requests to i.imgur.com are not being redirected to their HTTPS variant[/-][+]Doesn't rewrite URLs with wildcard targets in Firefox[/+][-]Doesn't rewrite URLs with wildcard targets in Firefox[/-][+]Doesn't rewrite URLs with wildcard targets in Firefox (includes *.gfycat.com, *.github.io, *.imgur.com, *.shopify.com, *.media.tumblr.com)[/+]cschanaj commentedon Aug 19, 2017
@Hainish would you make a release of the 5.2.21 (with the rulesets files from 2017.8.17) with automatic updates disabled (to be shipped with the
tor-browser bundleas a temporary solution for tor-users/ advanced users)? For reasons being thattargets using wildcards, especially theleftwildcards are important domainsP.S. IMHO this special release shouldn't be distribute as a update. thanks.
Hainish commentedon Aug 19, 2017
a69918f fixes this issue. I'll try to make a release tomorrow.
As for a special release for Tor Browser, I've already instructed them how to make a release using
5.2.21removing the update channel and checking out the latest rules. Tor Browser builds in HTTPS Everywhere as part of their release process from signed tags, so it's not a matter of me making a special release for them.