Repository navigation
fix(mkconcore): allow node labels with no source file - #685
Open
yadavchiragg wants to merge 2 commits into
Open
yadavchiragg wants to merge 2 commits into
yadavchiragg wants to merge 2 commits into
Conversation
Maintainer confirmed port-only nodes (IN:/OUT:) are meant to be supported. validate no longer reports 'has no filename' for them; mkconcore already builds them. The test now asserts port-only nodes validate.
yadavchiragg
marked this pull request as ready for review
November 15, 2026 03:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #684
Problem:
mkconcore.pyraisesValueError: Node source file '' cannot be emptyfor any node whose label has an empty source part, such asIN:orOUT:. 22 of the.graphmlfiles in the repository have such port-only nodes (0mq/,measurements/,ratc/yuyu*learn*.graphml,testsou/), and none of them can be built. The rest ofmkconcore.pystill handles a node without a source file (it checkslen(sourcecode) != 0/if not sourcecodein several places), so the label validation is stricter than the generator.Change: only validate the source part with
safe_relpathwhen it is non-empty. Non-empty sources are validated exactly as before, so unsafe source paths are still rejected.Testing: new
tests/test_port_only_nodes.pyfinds every workflow in the repo that contains a port-only node and builds it for posix, windows and docker. On currentdevall 66 build cases fail; with this change all pass.ruff format --checkandruff checkare clean.