Skip to content

mkconcore.py rejects node labels with no source file ("IN:", "OUT:"), so 22 example workflows no longer build #684

Open

Description

@yadavchiragg

Problem: mkconcore.py now raises ValueError: Node source file '' cannot be empty for any node whose label has an empty source part, such as IN: or OUT:. 22 of the 129 .graphml files in the repo have such nodes (0mq/, measurements/, ratc/yuyu*learn*.graphml, testsou/), and none of them can be built. Example:

python3 mkconcore.py measurements/Throughput/client.graphml measurements/Throughput out posix
ValueError: Node source file '' cannot be empty

The rest of mkconcore.py still supports a node with no source file (about eight places check len(sourcecode) != 0 or if not sourcecode), so I believe this is a side effect of the label validation and not intended.

Proposal: only validate the source part with safe_relpath when it is non-empty (a 3-line change). With it, all 22 files generate a study. I can open a PR with a test that builds every workflow containing a port-only node. If rejecting empty sources is intended, then those example workflows should be fixed or removed instead; please tell me which you prefer.

Activity

  1. yadavchiragg commented on Nov 14, 2026

    @yadavchiragg
    Author

    Question before I send a fix: are port-only nodes like IN: / OUT: meant to be supported?
    mkconcore.py rejects them (empty source), and concore validate also rejects them ("has no filename", tested in tests/test_graph.py).
    If they are supported, I'll fix mkconcore.py and validate.py together, with tests.
    If not, the many bundled .graphml files that use them need cleaning up instead.
    Happy to do either, whichever you prefer. @pradeeban

  2. pradeeban commented on Nov 15, 2026

    @pradeeban
    Member

    Port-only nodes are meant to be pure input and output sources So, it makes sense to be fixed at that level, @yadavchiragg.

  3. yadavchiragg commented on Nov 15, 2026

    @yadavchiragg
    Author

    Thanks @pradeeban. I've pushed the fix at that level: mkconcore.py now accepts port-only nodes , and concore validate accepts them too (it previously rejected "has no filename", and I updated that test). tests/test_port_only_nodes.py builds every bundled workflow with a port-only node (posix, windows, docker). PR: #685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions