You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
mkconcore.py rejects node labels with no source file ("IN:", "OUT:"), so 22 example workflows no longer build #684
Problem:mkconcore.py now raises ValueError: Node source file '' cannot be empty for any node whose label has an empty source part, such as IN: or OUT:. 22 of the 129 .graphml files in the repo have such nodes (0mq/, measurements/, ratc/yuyu*learn*.graphml, testsou/), and none of them can be built. Example:
python3 mkconcore.py measurements/Throughput/client.graphml measurements/Throughput out posix
ValueError: Node source file '' cannot be empty
The rest of mkconcore.py still supports a node with no source file (about eight places check len(sourcecode) != 0 or if not sourcecode), so I believe this is a side effect of the label validation and not intended.
Proposal: only validate the source part with safe_relpath when it is non-empty (a 3-line change). With it, all 22 files generate a study. I can open a PR with a test that builds every workflow containing a port-only node. If rejecting empty sources is intended, then those example workflows should be fixed or removed instead; please tell me which you prefer.
Question before I send a fix: are port-only nodes like IN: / OUT: meant to be supported?
mkconcore.py rejects them (empty source), and concore validate also rejects them ("has no filename", tested in tests/test_graph.py).
If they are supported, I'll fix mkconcore.py and validate.py together, with tests.
If not, the many bundled .graphml files that use them need cleaning up instead.
Happy to do either, whichever you prefer. @pradeeban
Thanks @pradeeban. I've pushed the fix at that level: mkconcore.py now accepts port-only nodes , and concore validate accepts them too (it previously rejected "has no filename", and I updated that test). tests/test_port_only_nodes.py builds every bundled workflow with a port-only node (posix, windows, docker). PR: #685
Activity
yadavchiragg commentedon Nov 14, 2026
Question before I send a fix: are port-only nodes like
IN:/OUT:meant to be supported?mkconcore.py rejects them (empty source), and
concore validatealso rejects them ("has no filename", tested in tests/test_graph.py).If they are supported, I'll fix mkconcore.py and validate.py together, with tests.
If not, the many bundled .graphml files that use them need cleaning up instead.
Happy to do either, whichever you prefer. @pradeeban
pradeeban commentedon Nov 15, 2026
Port-only nodes are meant to be pure input and output sources So, it makes sense to be fixed at that level, @yadavchiragg.
yadavchiragg commentedon Nov 15, 2026
Thanks @pradeeban. I've pushed the fix at that level: mkconcore.py now accepts port-only nodes , and
concore validateaccepts them too (it previously rejected "has no filename", and I updated that test). tests/test_port_only_nodes.py builds every bundled workflow with a port-only node (posix, windows, docker). PR: #685