Skip to content

test(docker): fail if mkconcore selects a Dockerfile template that doesn't exist - #689

Open
yadavchiragg wants to merge 2 commits into
ControlCore-Project:devfrom
yadavchiragg:test/docker-templates
Open

yadavchiragg wants to merge 2 commits into
ControlCore-Project:devfrom
yadavchiragg:test/docker-templates

Conversation

@yadavchiragg

Copy link
Copy Markdown

Why

Dockerfile.cpp was selected by mkconcore.py in docker mode but never existed in the repo, so every C++ docker build failed (fixed in #). CI never noticed because it only builds Dockerfile.py.

What

Adds tests/test_docker_templates.py, which runs in the existing test job (no Docker daemon needed):

  • parses mkconcore.py for every Dockerfile.<ext> it can select and asserts each file exists
  • compiles two sample C++ nodes with plain g++, the same way the generated Dockerfile does (skipped if g++ is missing)

Notes

mkconcore selects Dockerfile.cpp for .cpp nodes, but the template did not exist, so every docker build of a C++ workflow exited with a misleading 'not correct path to concore' error. Add the template, emit the g++ compile step and CMD like the Verilog path does, and narrow the bare except so a missing template names the actual file. Adds tests.
Parses mkconcore.py for the Dockerfile.<ext> templates it can pick in docker mode and asserts each is present, and compiles sample C++ nodes the way the generated Dockerfile does. This would have caught the missing Dockerfile.cpp.
@yadavchiragg yadavchiragg changed the title Test/docker templates test(docker): fail if mkconcore selects a Dockerfile template that doesn't exist Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant