Skip to content

Revise vertical spacing between elements - #261

Merged
GBKS merged 6 commits into
masterfrom
feature/revise-spacing
May 3, 2021
Merged

GBKS merged 6 commits into
masterfrom
feature/revise-spacing

Conversation

@GBKS

@GBKS GBKS commented Apr 26, 2021 •

Copy link
Copy Markdown
Contributor

A first PR to address issue #231.

The first part of this is more organizational to make the CSS easier to work with. Article.scss had grown hugely in size and become hard to work with. By splitting the CSS into individual files, it becomes easier to implement the fixes that have been requested for spacing.

The second part is addressing various spacing issues that had been mentioned over time.

The article CSS file has grown hugely with recent component additions. This first update splits them into separate files before making any changes.
@GBKS GBKS self-assigned this Apr 26, 2021
@GBKS GBKS added the Dev Development-focused tasks. label Apr 26, 2021
@GBKS GBKS linked an issue Apr 29, 2021 that may be closed by this pull request
@GBKS
GBKS requested review from ConorOkus and johnsBeharry April 29, 2021 07:15
@GBKS
GBKS marked this pull request as ready for review April 29, 2021 07:15
johnsBeharry
johnsBeharry previously approved these changes Apr 29, 2021
@johnsBeharry

Copy link
Copy Markdown
Contributor
  • Reported a few issues that been dealt with in 82d472b
  • Did not check for precise measurements stated in the Figma, instead looked for visual consistency

Useful debug css:

<style>* { outline: 1px solid red; }</style>

@ConorOkus

Copy link
Copy Markdown
Collaborator

Thanks for the improvement, did a very brief visual look through and the spacing between headers is a lot better 🚧

@GBKS
GBKS requested a review from johnsBeharry April 29, 2021 15:19
@GBKS
GBKS merged commit 6cf158d into master May 3, 2021
@danielnordh
danielnordh deleted the feature/revise-spacing branch September 17, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dev Development-focused tasks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revise vertical spacing between elements across the guide

4 participants