Skip to content

Create receive page in payments section - #240

Merged
pavlenex merged 27 commits into
BitcoinDesign:masterfrom
johnsBeharry:feature/receive
May 14, 2021
Merged

pavlenex merged 27 commits into
BitcoinDesign:masterfrom
johnsBeharry:feature/receive

Conversation

@johnsBeharry

Copy link
Copy Markdown
Contributor

Closes #174


Follow up page would touch on privacy of transactions including topics of wallet fingerprints (multisig vs signle sig), input/output ordering, coinjoins, and labeling to help users keep separate coin histories.

@danielnordh

Copy link
Copy Markdown
Contributor

As I had quite a lot of feedback on the text I copied the text into a doc and made suggestions there instead of clogging up this PR: https://docs.google.com/document/d/1PMgMIZ1fkC3SqJKWQBOrmJxefjmZhktqbSPZfzabmrE/edit?usp=sharing

@GBKS GBKS added the Copy Task is about improving text. label Apr 23, 2021

@pavlenex pavlenex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work really, I like the structure and the fact this page points out and tries to tackle some really common UX and even privacy problems by default (paying to legacy wallet, address re-use).

I feel like it lacks an illustration or two to better visualize what we mean. And the biggest thing that lacks here is more decisive recmendation, for SegWit with an option to switch (should be formatted in do's and don'ts) as I don't think it's clear for a designer what they should use.

Comment thread guide/payments/receive.md Resolved
Comment thread guide/payments/receive.md Resolved
Comment thread guide/payments/receive.md Resolved
Comment thread guide/payments/receive.md Resolved
Comment thread guide/payments/receive.md Resolved
Comment thread guide/payments/receive.md Resolved
Comment thread guide/payments/receive.md Resolved
Comment thread guide/payments/receive.md Resolved
Comment thread guide/payments/receive.md Resolved
Comment thread guide/payments/receive.md Outdated
-->

## Choosing the type of address
There are currently [three different versions](https://bitcoin.design/guide/glossary/#address) of bitcoin addresses. In order of oldest to newest they are; Legacy, Script, and SegWit. It is best practice for new applications to support SegWit, the latest, by default.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to relative link.

Comment thread guide/payments/receive.md Outdated

**Sixth confirmation** -- from this point the payment is finalized, it should be no problem to spend freely.

If your application has an area where the user can see a list of payment requests, this would be a good place to use it to also indicate which specific stage the payment is in.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several screens with lists of transaction in the wallet UI kit we can use here. Check it.

Co-authored-by: Daniel Nordh <daniel@mutinyserver.com>
Comment thread guide/payments/receive.md Outdated
Although addresses are not a problem to share publically, their accompanying private keys which typically generated from a single recovery phrase must be kept secure and private.
-->

## Creating an invoice

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GBKS @pavlenex thoughts on referring to generating an address and adding metadata to it as an invoice? I previously called it payment requests, and @danielnordh prefers that as it is less corporate/businessy.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find invoice to be more of business term than payment request (thinking about which terms I'd use with friends vs. business purposes). So my vote would be for payment request (despite it being longer).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer an invoice, easier to translate, the payment request is not a regular term in my opinion.

@johnsBeharry johnsBeharry Apr 29, 2021 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we start talking about LN, it's all about invoices there, and some of the additional data is going to be more built-in.

Invoice

Payment Request

👆 this is old deprecated BIP but still has some good ideas around signed messaged that will probably be rehashed.

@danielnordh danielnordh Apr 29, 2021 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented a bit more on this part in the doc

My feedback is basically:

  • If 'invoice' is not a defined standard in Bitcoin, let's not push for it as it doesn't really make sense for end users (maybe for merchants, but that's not what we are tackling here)
  • We don't not need to talk about this as creating an 'object', so instead of saying 'Create an invoice/payment request', we can simply say 'Requesting bitcoin' as a subtitle. For the user it's an action, not an object.
  • IF the user is asked/able to enter additional information other than the address, it should be clear to them if that information is SHARED with the person they want to request bitcoin from, or not

The subtitle and the following paragraph could then be:

Requesting bitcoin

The simplest form of requesting bitcoin is to create and share a bitcoin address where the sender should direct the payment. Generating a new address and showing it as a QR code and plain text is the most common way for applications to help users request bitcoin.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point about this object-creation idea. I prefer the simpler language that avoids that concept and focuses on the action.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't dismiss the object creation idea - as sending bitcoin is very much action oriented flow, the act of requesting bitcoin has artefacts that the designer would need to consider in other areas of the application and would benefit from understanding that object and its properties. So I think in this case it would be very well suited.

Since this comment though, the state of the page has gone towards something which is more action oriented, I'll probably bring it up at another point though after the chapter complete for v1.

GBKS added a commit that referenced this pull request Apr 29, 2021
johnsBeharry and others added 4 commits April 29, 2021 18:32
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Daniel Nordh <3393669+danielnordh@users.noreply.github.com>
…tcoin

Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Daniel Nordh <3393669+danielnordh@users.noreply.github.com>
Comment thread guide/payments/receive.md Resolved
Comment thread guide/payments/receive.md Resolved
Comment thread guide/payments/receive.md Resolved
Comment thread guide/payments/receive.md Outdated

As the blockchain only stores the amount and addresses involved in a transaction, any additional information has to be stored in your application, or encoded in payment links. It's up to you to decide how and if you allow receivers to enter these additional details.

It's up to you to find the balance between a payment flow that is optimized to quickly generate and share addresses, and one that prompts them to describe the payment so they can use it in the future to have more context about what payment was for.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about something like this:

Many wallet applications focus on a minimal interface for requesting payments. This is convenient in the short-term, but may not be the users best interest longer-term. Lists of transactions without information about who they are from and what the purpose was make it hard to manage personal finances. Try to find the right balance in convenience and usefulness for your target audience.

Co-authored-by: Christoph Ono <chri@sto.ph>
Comment thread guide/payments/receive.md Resolved
Comment thread guide/payments/receive.md Resolved
Comment thread guide/payments/receive.md Resolved
Comment thread guide/payments/receive.md
Since bitcoin is a open system and has many payment applications built ontop of it, there is a [standard format]({{ '/guide/foundations/wallet-interoperability/#payment-links' | relative_url }}) of "payment links" that most bitcoin applications use to share payment details.
-->

## Sharing the payment request

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Sharing the payment request
## Sharing the request

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also with this one, i think its just clear to have the payment part in here. the payment request concept is something that will be in other places in this chapter I expect so might as well readers familiar with it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You decide. I think it's pretty clear from the page context that it's about payments but up to you.

Comment thread guide/payments/receive.md Resolved
Comment thread guide/payments/receive.md Resolved
Comment thread guide/payments/receive.md Resolved
Comment thread guide/payments/receive.md Resolved
Comment thread guide/payments/receive.md Resolved
Comment thread guide/payments/receive.md Resolved
johnsBeharry and others added 3 commits May 13, 2021 03:22
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Daniel Nordh <3393669+danielnordh@users.noreply.github.com>
Co-authored-by: bosch <55287964+Bosch-0@users.noreply.github.com>
Bosch-0
Bosch-0 previously approved these changes May 13, 2021
@johnsBeharry

Copy link
Copy Markdown
Contributor Author

Fixed merge conflicts, at least until another PR gets merged into master.

Bosch-0
Bosch-0 previously approved these changes May 14, 2021
pavlenex
pavlenex previously approved these changes May 14, 2021

@pavlenex pavlenex left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK.

Let's get this one merged today if no major blockers, by the look of it, looks ready to go🚀

BTW Mom, I made it!

Screenshot 2021-05-14 at 10 06 18

Comment thread guide/payments/send.md Resolved
Co-authored-by: Christoph Ono <chri@sto.ph>
@pavlenex
pavlenex dismissed stale reviews from Bosch-0 and themself via 8df761e May 14, 2021 08:28
@pavlenex
pavlenex merged commit 3833229 into BitcoinDesign:master May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Copy Task is about improving text.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create page for Receiving bitcoin

5 participants