Skip to content

Revise vertical spacing between elements across the guide #231

Closed

Description

@GBKS

This has come up a handful of times already and has let to some one-off fixes that then have negative effects on other pages. Let's lay out the rules in Figma first and then port them to CSS.

Activity

  1. added
    DesignTask is about designing something.
    on Apr 14, 2021
  2. self-assigned this
    on Apr 14, 2021
  3. linked a pull request that will close this issueRevise vertical spacing between elements #261on Apr 29, 2021
  4. GBKS commented on Apr 29, 2021

    @GBKS
    ContributorAuthor

    I laid out the various spacing rules in Figma. Check it.

    Overall, this is not a huge departure from what we already have. Thing is that we just have various fringe cases that cannot be easily handled via basic CSS rules. For example, we don't use regular top margins for headers, because of deep-linking (see #102). This prevents margin collapsing and requires various additional CSS rules.

    So this task ended up being mostly around cleaning up and standardizing, as well as adding a few specific CSS rules for those gaps that we had.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

DesignTask is about designing something.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions