You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Revise vertical spacing between elements across the guide #231
This has come up a handful of times already and has let to some one-off fixes that then have negative effects on other pages. Let's lay out the rules in Figma first and then port them to CSS.
I laid out the various spacing rules in Figma. Check it.
Overall, this is not a huge departure from what we already have. Thing is that we just have various fringe cases that cannot be easily handled via basic CSS rules. For example, we don't use regular top margins for headers, because of deep-linking (see #102). This prevents margin collapsing and requires various additional CSS rules.
So this task ended up being mostly around cleaning up and standardizing, as well as adding a few specific CSS rules for those gaps that we had.
Activity
GBKS commentedon Apr 29, 2021
I laid out the various spacing rules in Figma. Check it.
Overall, this is not a huge departure from what we already have. Thing is that we just have various fringe cases that cannot be easily handled via basic CSS rules. For example, we don't use regular top margins for headers, because of deep-linking (see #102). This prevents margin collapsing and requires various additional CSS rules.
So this task ended up being mostly around cleaning up and standardizing, as well as adding a few specific CSS rules for those gaps that we had.