Skip to content

Another attempt at fixing header spacing for deep links - #102

Merged
johnsBeharry merged 2 commits into
masterfrom
feature/header-spacing-fix
Jan 16, 2021
Merged

johnsBeharry merged 2 commits into
masterfrom
feature/header-spacing-fix

Conversation

@GBKS

@GBKS GBKS commented Jan 8, 2021

Copy link
Copy Markdown
Contributor

This approach only applies to h2 to h6.
Uses hidden elements for spacing (instead of padding/margin) with a negative offset (as @johnsBeharry solution did before).
Fixes the issue that the hidden element blocks interaction with the home page banner with relative positioning and z-index.

Need to test this properly as we had a fix before that we removed because it caused issues (see above).

This approach only applies to h2 to h6.
Uses hidden elements for spacing (instead of padding/margin) with a negative offset (as Johns solution did before).
Fixes the issue that the hidden element blocks interaction with the home page banner with relative positioning and z-index.
@GBKS GBKS added the Dev Development-focused tasks. label Jan 8, 2021
@GBKS GBKS self-assigned this Jan 8, 2021
@johnsBeharry

Copy link
Copy Markdown
Contributor

Seems to check out, and looks better than whats currently live - fixes the vertical spacing again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dev Development-focused tasks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants