Repository navigation
Another attempt at fixing header spacing for deep links - #102
Merged
Merged
Conversation
This approach only applies to h2 to h6. Uses hidden elements for spacing (instead of padding/margin) with a negative offset (as Johns solution did before). Fixes the issue that the hidden element blocks interaction with the home page banner with relative positioning and z-index.
Contributor
|
Seems to check out, and looks better than whats currently live - fixes the vertical spacing again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This approach only applies to h2 to h6.
Uses hidden elements for spacing (instead of padding/margin) with a negative offset (as @johnsBeharry solution did before).
Fixes the issue that the hidden element blocks interaction with the home page banner with relative positioning and z-index.
Need to test this properly as we had a fix before that we removed because it caused issues (see above).