Skip to content

Inheritance wallet - Part 3 - Cosigner onboarding & key replacement - #1091

Closed
rabbitholiness wants to merge 79 commits into
BitcoinDesign:masterfrom
rabbitholiness:inheritance-wallet-part3-change-management
Closed

rabbitholiness wants to merge 79 commits into
BitcoinDesign:masterfrom
rabbitholiness:inheritance-wallet-part3-change-management

Conversation

@rabbitholiness

@rabbitholiness rabbitholiness commented May 14, 2024 •

Copy link
Copy Markdown
Collaborator

This PR builds on the previous inheritance wallet PRs:
Part 1: Use case & wallet creation
Part 2: Wallet backup

It adds a page about how Alice is set up as a cosigner for the family savings wallet. It also adds a page about how making changes work, like key replacement or editing timelocks.

@netlify

netlify Bot commented May 14, 2024 •

Copy link
Copy Markdown

✅ Deploy Preview for bitcoin-design-site ready!

Name Link
🔨 Latest commit 791a7c3
🔍 Latest deploy log https://app.netlify.com/sites/bitcoin-design-site/deploys/66753c38ca3a530008e45efc
😎 Deploy Preview https://deploy-preview-1091--bitcoin-design-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rabbitholiness rabbitholiness self-assigned this May 14, 2024
@rabbitholiness rabbitholiness added the Inheritance wallet Referring to the inheritance wallet reference design. label May 14, 2024
@rabbitholiness

Copy link
Copy Markdown
Collaborator Author

Opened this PR in draft mode so far, so that people can look at it. There's quite a few things to tweak:

  • Image captions & alt-texts
  • Consistency checks
  • Navigation & reference links
  • Potentially additional clickable prototypes

@rabbitholiness
rabbitholiness marked this pull request as ready for review May 16, 2024 14:17
@rabbitholiness

Copy link
Copy Markdown
Collaborator Author

Opening this up for initial feedback, even if there are two things left to do:

  • Write alt-texts for the 66 images in this PR 😊
  • Create a visual for the "how it works" section of the "Making changes" page, for better clarity.

@mouxdesign mouxdesign left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some comments on the use of specific names of hardware wallets. I would recommend avoiding those so that the copy remains timeless and not brand specific.

So far, the wallet has been created on Bob's app. The next step is to get Alice set up as a cosigner and to enable her to sign transactions. To do this Alice needs to:

1. Import the wallet configuration to her app.
2. Enable her Bitbox to sign transactions.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. Enable her Bitbox to sign transactions.
2. Enable her hardware wallet to sign transactions.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see your point. However, I would probably keep the device names. I know they're brands, but I think it's easier for the reader to follow along, if they are specific examples. In addition, these brands have been around for a long time, so I wouldn't be too worried about that.

@GBKS GBKS Jun 24, 2024 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we make up our own brands - BitGuard, CoinSafe, and BlockVault? I've done this before with mock-ups and it usually works well.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example:

image

rabbitholiness and others added 3 commits June 17, 2024 15:13
Co-authored-by: Mogashni  <90313394+mouxdesign@users.noreply.github.com>
Co-authored-by: Mogashni  <90313394+mouxdesign@users.noreply.github.com>

@GBKS GBKS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just some minor feedback.


---

So far, the wallet has been created on Bob's app. The next step is to get Alice set up as a cosigner and to enable her to sign transactions. To do this Alice needs to:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far could link back to the point you are referring to. Users can of course figure it out themselves, but you might as well save them that small effort.


Editor's notes

This page covers a multi-key wallet that uses timelocks to provide additional recovery options.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjust to this page.

images_alice-enable-device:
- file: alice-enable-device/enable-alice-home
alt: Home screen showing the wallet with two tasks associated.
caption: Alice is ready to enable her Bitbox to sign transactions for the wallet.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
caption: Alice is ready to enable her Bitbox to sign transactions for the wallet.
caption: Alice is ready to enable her BitBox to sign transactions for the wallet.

The second B is also capitalized. Make sure to update that across your PRs.


### Replacing a signing key

Let's assume that David has lost his signing device. He did not lose the seed phrase backup, so he could theoretically just import his private key into a new device. But since they are dealing with their family savings, the Joneses don't want to take any chances. They decide to replace David's key, which is part of the inheritance key set, with a new one. They would follow the same approach if David had lost the seed phrase backup or had reason to believe that it had been compromised.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They would follow the same approach if David had lost the seed phrase backup

Why is that? Can't he just recreate it from his signing device? Is it because someone might find the lost backup?

2. Activate the new wallet on their signing devices.
3. Save the backup kit for the new wallet.

We have covered these topics in the previous pages of this reference design.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add links?


#### Alice co-signs the transaction

On the app home screen, Alice now sees a reminder that a transaction is ready to be signed. On the detail screen, she also sees that Bob has already provided a signature. Alice hits "sign" and goes through the transaction signing flow on her Bitbox.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now sees a reminder that a transaction is ready to be signed

How does the app know about the transaction? Is there a server handling communication? If not, then Bob would have to share the PSBT.


After she has signed the transaction, she sees that the transaction is being confirmed by the network. Once the transaction has been confirmed, the app home screen shows a reminder that the original wallet should be archived.

### Archiving the old wallet

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could cross-link to the archival paragraph in the multi-wallet page somewhere.

@rabbitholiness
rabbitholiness deleted the inheritance-wallet-part3-change-management branch July 8, 2024 10:56
@rabbitholiness

Copy link
Copy Markdown
Collaborator Author

I will open a new PR, as I had technical issues with the existing branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Inheritance wallet Referring to the inheritance wallet reference design.

Projects

Development

Successfully merging this pull request may close these issues.

3 participants