Skip to content

Inheritance wallet - Part 2 - Backup - #1087

Closed
rabbitholiness wants to merge 80 commits into
BitcoinDesign:masterfrom
rabbitholiness:inheritance-wallet-part2-backup
Closed

rabbitholiness wants to merge 80 commits into
BitcoinDesign:masterfrom
rabbitholiness:inheritance-wallet-part2-backup

Conversation

@rabbitholiness

@rabbitholiness rabbitholiness commented May 2, 2024 •

Copy link
Copy Markdown
Collaborator

This PR builds on Part 1 of the Family Inheritance Wallet reference design.

This page discusses how the backup process works and how the Joneses store and distribute different components of the backup material.

👁️ Check the preview here 👁️

@rabbitholiness
rabbitholiness marked this pull request as ready for review May 6, 2024 09:26

@mouxdesign mouxdesign left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read through the copy, quite an intricate topic here but the diagrams are a great thing which accompany the copy.
Added in some ideas about the images mostly and how they compliment the copy itself.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the diagram the word wallet descriptor is used, however in the copy wallet configuration is used in the opening paragraph and the copy below the image. Might be good to choose one term and use to it both with image and copy.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wallet descriptor copy in image:
"A small piece of text", further below in the copy it seems that the small piece of text is the backup kit. Might be worth changing the copy in the image to keep it consistent.

If I understand correctly the backup kit is exportable as a ZIP file.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to image copy:
Heading: Wallet configuration.
Body copy: A pdf file as well as wallet backup files in various contexts that a wallet would need to recover a multi-key wallet.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated and rephrased. Hope it makes more sense now.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might make more sense here to create an example of one wallet, for understanding the context of the image more. one wallet name then showing many different file types. The image used does make sense as it seems you are trying to convey that different wallets can use different file types but the relatedness of those file types is confusing visually. If that relatedness could be grouped or shown, might make more sense.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated and made a more concrete example. Hope it's clearer now.

Comment thread guide/inheritance-wallet/backup.md Resolved
Comment thread guide/inheritance-wallet/backup.md Resolved
Comment thread guide/inheritance-wallet/backup.md Resolved

@yashrajd yashrajd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd been eagerly waiting for the backup page PR, so happy to see how it's turning out. The sections on backup distribution & assembly are especially great IMO.

Hope my inputs are helpful, if some of them look convoluted to do reach out.

Comment thread guide/inheritance-wallet/backup.md Resolved
Comment thread guide/inheritance-wallet/backup.md Resolved
Comment thread guide/inheritance-wallet/backup.md Resolved
Comment thread guide/inheritance-wallet/backup.md Resolved
Comment thread guide/inheritance-wallet/backup.md Resolved
Comment thread guide/inheritance-wallet/backup.md Resolved
Comment thread guide/inheritance-wallet/backup.md Resolved
Comment thread guide/inheritance-wallet/backup.md Resolved
Comment thread guide/inheritance-wallet/backup.md Resolved
Comment thread guide/inheritance-wallet/backup.md Resolved
rabbitholiness and others added 8 commits May 14, 2024 08:24
Co-authored-by: Mogashni  <90313394+mouxdesign@users.noreply.github.com>
Co-authored-by: yashrajd <114083781+yashrajd@users.noreply.github.com>
Co-authored-by: yashrajd <114083781+yashrajd@users.noreply.github.com>
Co-authored-by: yashrajd <114083781+yashrajd@users.noreply.github.com>
Co-authored-by: yashrajd <114083781+yashrajd@users.noreply.github.com>
Co-authored-by: yashrajd <114083781+yashrajd@users.noreply.github.com>
Co-authored-by: yashrajd <114083781+yashrajd@users.noreply.github.com>
Co-authored-by: yashrajd <114083781+yashrajd@users.noreply.github.com>
@rabbitholiness rabbitholiness added the Inheritance wallet Referring to the inheritance wallet reference design. label May 14, 2024
rabbitholiness and others added 3 commits May 29, 2024 14:22

@GBKS GBKS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just had some minor comments. Make sure that images are as legible as possible on mobile by providing vertical layouts as needed.

{% include picture.html
image = "/assets/images/guide/inheritance-wallet/wallet-backup/multikey-backup-components.png"
retina = "/assets/images/guide/inheritance-wallet/wallet-backup/multikey-backup-components@2x.png"
alt-text = "A idagram showing the two parts of a multi-key wallet backup."

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
alt-text = "A idagram showing the two parts of a multi-key wallet backup."
alt-text = "A diagram showing the two parts of a multi-key wallet backup."


The inheritance wallet described in this reference design is a multi-key wallet with time-based recovery. When backing up such a wallet, users must back up not only their own private keys but also the wallet configuration, as covered [here](https://bitcoin.design/guide/savings-wallet/time-based-recovery/#wallet-backup).

{% include picture.html

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The information definitely looks nicer as an image, but is also less accessible and super hard to read on mobile. You could. You could pull the text into the HTML or add a separate mobile image with a vertical layout.


---

The inheritance wallet described in this reference design is a multi-key wallet with time-based recovery. When backing up such a wallet, users must back up not only their own private keys but also the wallet configuration, as covered [here](https://bitcoin.design/guide/savings-wallet/time-based-recovery/#wallet-backup).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to use relative links instead of absolute ones. Several instances of that on this page.


Alice and Bob are not willing to trust their life savings to one application. That's why they carefully chose the way in which they store the above wallet backup material. The illustration below shows the chosen setup in more detail.

{% include picture.html

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to add a mobile version with a vertical layout for easier reading.

modalHeight = 1850
%}

Please note that this is one of many possible ways to approach wallet backups and should not be understood as the only correct way to do it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use tip formatting here.


It is important that users determine the best way to handle backups based on their own specific circumstances. Factors that will influence such decisions include the relationship between family members, the amount of funds stored, their access to safe locations, etc. Based on these and other factors it can be more appropriate to chose a simpler or more advanced backup scheme.

We would also like to reiterate the point made in the "Use case & scope" page: the complexity of the backup scheme increases with the complexity of the wallet configuration. Therefore, user education is critical during wallet creation as well as during the backup phase.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Use case & scope"

Best to make that a link.

@GBKS GBKS changed the title Inheritance Wallet Reference Design - Chapter 2 - Backup Inheritance wallet - Part 2 - Backup Jun 24, 2024
@rabbitholiness
rabbitholiness deleted the inheritance-wallet-part2-backup branch July 8, 2024 10:51
@rabbitholiness

Copy link
Copy Markdown
Collaborator Author

I'll open a new PR as I had technical issues with this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Inheritance wallet Referring to the inheritance wallet reference design.

Projects

Development

Successfully merging this pull request may close these issues.

4 participants