Skip to content

Inheritance wallet - Part 1 - #1081

Merged
GBKS merged 75 commits into
masterfrom
family-inheritance-wallet-reference-design
Jul 2, 2024
Merged

GBKS merged 75 commits into
masterfrom
family-inheritance-wallet-reference-design

Conversation

@rabbitholiness

@rabbitholiness rabbitholiness commented Mar 18, 2024 •

Copy link
Copy Markdown
Collaborator

This multi-page reference design looks at a multi-key wallet for family savings. It includes a recovery path as well as a timelocked inheritance key set. Apart from wallet creation, the reference design also addresses topics like wallet backups, key rotation and recovery.

This PR addresses the first part of the series, which will cover the landing page, the use case description and the wallet creation flow. The outline of the entire reference design is described on the landing page and marked as "coming soon". The remaining pages will be added step by step.

👉 Preview it here 👈

@rabbitholiness rabbitholiness self-assigned this Mar 18, 2024
@netlify

netlify Bot commented Mar 18, 2024 •

Copy link
Copy Markdown

✅ Deploy Preview for bitcoin-design-site ready!

Name Link
🔨 Latest commit ceedadf
🔍 Latest deploy log https://app.netlify.com/sites/bitcoin-design-site/deploys/6682bc898617ce00085ae25f
😎 Deploy Preview https://deploy-preview-1081--bitcoin-design-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@GBKS GBKS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good. Just had a few minor comments.

I also recommend running the images through a compression tool like ImageOptim. You can cut the file size by 50-80%.

In the wallet creation page, I think the file coming-soon-placeholder.png is not used anymore. Most likely you have more unused images in there. You use 56 visuals in image galleries, which means 112 images. Then there are 4 images for the prototype, for a total of 116. But the wallet creation folder includes 129 images. Maybe another 12 unused ones in there?

rabbitholiness and others added 4 commits June 24, 2024 13:22
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
@GBKS GBKS changed the title Family inheritance wallet reference design - Part 1 Inheritance wallet - Part 1 Jun 24, 2024
@rabbitholiness

Copy link
Copy Markdown
Collaborator Author

Looks really good. Just had a few minor comments.

I also recommend running the images through a compression tool like ImageOptim. You can cut the file size by 50-80%.

In the wallet creation page, I think the file coming-soon-placeholder.png is not used anymore. Most likely you have more unused images in there. You use 56 visuals in image galleries, which means 112 images. Then there are 4 images for the prototype, for a total of 116. But the wallet creation folder includes 129 images. Maybe another 12 unused ones in there?

Should all be addressed now. Took some digging but I found the superfluous images :-)

@GBKS GBKS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more tweaks.

Comment thread guide/inheritance-wallet/overview.md Resolved
Comment thread guide/inheritance-wallet/overview.md Resolved
Comment thread guide/inheritance-wallet/overview.md Resolved
@rabbitholiness

Copy link
Copy Markdown
Collaborator Author

@GBKS do you think we can get this one merged?

GBKS
GBKS previously approved these changes Jul 1, 2024

@GBKS GBKS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Looks great. Thanks for addressing all my nitpicky feedback. Let's get this one out the door.

@mouxdesign

mouxdesign commented Jul 1, 2024 •

Copy link
Copy Markdown
Collaborator

Looks good to fly Michael.

One small comment is that the icon for the wallet backup is not showing up on my screen.

Screenshot 2024-07-01 111709

@GBKS GBKS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-acking.

@GBKS
GBKS merged commit 4fa57bf into master Jul 2, 2024
@GBKS
GBKS deleted the family-inheritance-wallet-reference-design branch July 2, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Inheritance wallet Referring to the inheritance wallet reference design.

Projects

Development

Successfully merging this pull request may close these issues.

5 participants