This repository was archived by the owner on May 22, 2025. It is now read-only.
Repository navigation
Deletes all gamemodes in favor of storytellers - #22661
Merged
Merged
Conversation
This reverts commit ff93cf1.
Yogbot-13
added a commit
that referenced
this pull request
Oct 10, 2024
Yogbot-13
added a commit
that referenced
this pull request
Oct 10, 2024
This was referenced Oct 11, 2024
Yogbot-13
added a commit
that referenced
this pull request
Oct 11, 2024
Yogbot-13
added a commit
that referenced
this pull request
Oct 15, 2024
Yogbot-13
added a commit
that referenced
this pull request
Oct 16, 2024
Yogbot-13
added a commit
that referenced
this pull request
Oct 18, 2024
This was referenced Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an extension of #22565
That pr works (mostly) and is stable enough to leave testmerged for the time being
This pr goes further, removing all gamemodes as storytellers make them obsolete.
Removing gamemodes will improve code maintainability in the future, as well as reduce code bloat.
However, a number of unrelated features relied on game modes to work, so while removing them, i noticed that it would become far more unstable for the time being.
Rather than risk messing up that original pr, i made a new branch, that is this
Now for how the system itself works
Storytellers
It works by using the existing event system that was previously only for midround events, but develops it further
It has 5 different event tracks
Each event also has a list of tags, such as
The storytellers work by having a "storyteller" generate points over time for each track
Once a track reaches a certain threshold, the "storyteller" will buy an event from that track
The event purchased will be determined by
Different types of storytellers can be made to convey different game feelings
Adding new events to this system is easier than making new event for dynamic, and they're going to spawn in more varied amounts compared to the old events + gamemode system
Why is this good for the game?
Dynamic is less dynamic than would be ideal and requires more work to update, maintain, and improve that we have
Storytellers is both more flexible to start, and is a lot easier to understand from a coding perspective, making it far less of a resource drain on our dev team to maintain
Testing
why should i need to test this
🆑 Biome, Molti, Dwasint, & other Monke devs
rscadd: Adds storytellers
rscdel: Deletes literally all gamemodes, buh bye
tweak: so many round events, like, genuinely so much
/:cl: