This repository was archived by the owner on May 22, 2025. It is now read-only.
Repository navigation
Storytellers - #22565
Closed
ToasterBiome wants to merge 128 commits into
Closed
Storytellers#22565ToasterBiome wants to merge 128 commits into
ToasterBiome wants to merge 128 commits into
Conversation
Yogbot-13
added
Feature
ToasterBiome
marked this pull request as draft
August 29, 2024 00:03
github-actions
Bot
added
Admin
Contributor
|
Hopefully will make boring as hell rounds actually have something going on!!! (idk what storytellers really do) |
Contributor
|
What are the effects of adding this feature? |
Contributor
|
Hell yea |
Moltijoe
marked this pull request as ready for review
September 11, 2024 02:14
Yogbot-13
added a commit
that referenced
this pull request
Sep 29, 2024
Contributor
Author
|
just use #22661 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filled out by Molti, not biome
ported from
Monkestation/Monkestation2.0#461
Monkestation/Monkestation2.0#549
Monkestation/Monkestation2.0#552
Monkestation/Monkestation2.0#622
Monkestation/Monkestation2.0#952
Monkestation/Monkestation2.0#1135
Monkestation/Monkestation2.0#1427
among others (really just sorta stole it directly from their current codebase)
Why is this good for the game?
Dynamic is less dynamic than would be ideal and requires more work to update, maintain, and improve that we have
Storytellers is both more flexible to start, and is a lot easier to understand from a coding perspective, making it far less of a resource drain on our dev team to maintain
Testing
constant work in progress
Wiki Documentation
good luck mord
🆑
rscadd: Adds the storytellers from Monke (and originally horizon)
rscdel: Expunges dynamic from the codebase
/:cl: