Repository navigation
Conversation
DuckDB's V2 scan builds the same ScanRequest as its V1 scan, scans the file's plan data source and opens it, and each thread polls a clone of the stream, as for V1. The private V2 queue in scan_v2.rs goes away, and progress comes from ScanStream::progress for both executors. Signed-off-by: Nicholas Gates <nick@nickgates.com> Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…b-v2 Signed-off-by: Nicholas Gates <nick@nickgates.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…b-v2 Signed-off-by: Nicholas Gates <nick@nickgates.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both executors now bind the projection against each file through ScanRequest, so the bound copy in GlobalState and its helper go. Signed-off-by: Nicholas Gates <nick@nickgates.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…b-v2 Signed-off-by: Nicholas Gates <nick@nickgates.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #9062
DuckDB's V2 scan reads through the Scan API the way its V1 scan does. For each file it builds the same
ScanRequestas the V1 path, callsscanon the file'splan_data_sourceandopens it once, and each DuckDB thread polls a clone of the stream withRUNTIME.block_on(stream.next()). A thread joins a file until the first clone ends, and DuckDB's progress bar readsScanStream::progressfor both executors.Split::V2,FileScanand the private part queue inscan_v2.rsare gone, so DuckDB has one scan path whatever the executor. Files are openedwith_cachingso the V2 splitter reuses the layout reader DuckDB already builds. V2 batches that join several layout chunks are still exported chunk by chunk, so DuckDB evaluates expressions over each chunk's dictionary once.This PR is one layer of experiment A, which tests one decision about the Scan API: whether
DataSourceScan::open(), a cloneable asyncScanStreamthat each host thread polls, is enough for the V2 scan engine, or whether a host needs V2's synchronous step. The stack puts the V2 engine behindopen()and moves DuckDB's V2 scan onto it. The gate is DuckDB V2 on TPC-H and ClickBench within noise of develop's DuckDB V2, measured on the last layer with rotated runs. If V2 cannot reach parity through the stream, the experiment stops and reports what the engine needs thatScanStreamcannot express, with profile evidence, rather than tuning around it. This is the layer the benchmark measures.What the port shows about the trait, as findings:
ScanStreamis notSync, so DuckDB clones a file's stream under a mutex, for V2 as for V1.scan(), andopen()andsplit()read nothing. For the V2 source that read is the whole-file prune of a dynamic filter, which therefore runs when DuckDB initializes a file. Breaking the rule is measurable: with that prune on the first poll of a clone, ClickBench q25, a top-N with a dynamic filter, runs 9.5% slower than develop, against 3% with it inscan().ScanRequest::split_concurrencymeans nothing to V2: a clone always runs one part at a time.Stacked on #11716
🤖 Generated with Claude Code