Repository navigation
Conversation
VortexFile::plan_data_source scans one file through PlanDataSource and plan_child makes a file a child of one, with the file's statistics pruning scans they rule out and its layout splits over the fields a scan reads cutting the scan's parts, as a V1 scan cuts its splits. Both are opt-in: data_source() still scans with the layout reader, which layout_reader_data_source names explicitly. Signed-off-by: Nicholas Gates <nick@nickgates.com> Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…source Signed-off-by: Nicholas Gates <nick@nickgates.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…source Signed-off-by: Nicholas Gates <nick@nickgates.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…source Signed-off-by: Nicholas Gates <nick@nickgates.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #9062
Adds
VortexFile::plan_data_sourceandplan_child, which expose a file as aPlanDataSourcechild.data_source()still returns the layout-reader source, andlayout_reader_data_sourcenames that path explicitly.A file's child carries the three things the source needs without reading payloads: the file's row count, a pruner that tests the filter against the footer's file statistics, and a splitter. The splitter cuts the file's work at its layout splits over the fields a scan reads, the same boundaries a V1 scan of those fields uses, so V1 and V2 parallelise a file at the same grain. The splitter reads the file's layout reader, so a file opened
with_cachingbuilds that reader once.FileDataSource<S>wraps either executor's source with the file's footer statistics, so both answerfield_statisticswithout reading payloads. Tests run the same reads on both executors and compare them.This PR is one layer of experiment A, which tests one decision about the Scan API: whether
DataSourceScan::open(), a cloneable asyncScanStreamthat each host thread polls, is enough for the V2 scan engine, or whether a host needs V2's synchronous step. The stack puts the V2 engine behindopen()and moves DuckDB's V2 scan onto it. The gate is DuckDB V2 on TPC-H and ClickBench within noise of develop's DuckDB V2, measured on the last layer with rotated runs. If V2 cannot reach parity through the stream, the experiment stops and reports what the engine needs thatScanStreamcannot express, with profile evidence, rather than tuning around it.Stacked on #11715
🤖 Generated with Claude Code