Repository navigation
Conversation
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
This was referenced Nov 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build mixed Vortex/DF expression trees for scan filters and projections. Compatible operators remain native, unsupported fragments share typed DF callbacks, and conditional evaluation, Scalar-versus-Array shape, UDF-visible fields, and numeric behavior are preserved.
Prerequisites, reviewed independently:
The temporary review base
dk/df-expression-prerequisitescombines those two prerequisites so this diff contains only their consumer. Keep this PR draft until both land; then rebase and retarget todevelop. Do not merge into the temporary review base.The consumer overrides advisory conversion for whole positive optional filters, including partition-routing CASE/hash membership, while retaining DataFusion's exact enforcement and generation tracking. Seven focused mixed-expression tests and existing converter/scan tests cover the new behavior. Existing code keeps its original import/name style; unrelated qualification churn was removed.
Before merge: eliminate per-node
return_fieldcalls that repeatedly format whole subtrees. Memoization alone does not establish linear planning complexity.Replaces the consumer portion of #11432. The original implementation had targeted checks; no builds, tests, or formatters were rerun for this source-reviewed split. Prepared with Codex; split commits reviewed in the designated review chat. @danking