Skip to content

Allow advisory filter conversion overrides - #11667

Open
danking wants to merge 2 commits into
developfrom
dk/advisory-conversion-api
Open

danking wants to merge 2 commits into
developfrom
dk/advisory-conversion-api

Conversation

@danking

@danking danking commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Dynamic scan hints currently use exact expression conversion followed by an infallibility check. Add a provided ExpressionConverter::try_convert_dynamic hook so custom converters can produce conservative, error-safe advisory filters. Its default preserves the existing infallibility gate; exact filter and projection conversion is unchanged.

Use the hook both when accepting a dynamic filter and when converting its later snapshot conjuncts. Two focused tests cover the default gate and file-backed scan-adapter dispatch with residual enforcement retained.

Extracted from #11432 and independent of the typed expression shim in #11431. Consumer implementation: #11669.

Updated against current develop. No builds or tests were run for this extraction, following the repository's verification policy. Source reviewed in the designated Codex review chat.

Prepared with Codex. @danking

Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
@codspeed

codspeed Bot commented Nov 19, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 12.31%

2 warnings

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ 1 benchmark is dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚡ 2 improved benchmarks
✅ 1980 untouched benchmarks
⏩ 57 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Walltime random_rotating_avx2[(0.9, 0.9, "self_90pct_mask_90pct")] 9.5 µs 8.3 µs +14.15%
⚡ Walltime decode_avx512[DeltaU8] 11 µs 10 µs +10.51%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing dk/advisory-conversion-api (31f91d7) with develop (d368834)

Open in CodSpeed

Footnotes

  1. 57 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant