Repository navigation
Conversation
Engines that consume the Scan API still scanned Vortex files with the V1 layout reader. PlanDataSource exposes any ScanInput as a DataSource whose single partition runs on the planner-driven ScanDriver, and VortexFile::data_source now uses it, falling back to the layout reader for files with list layouts, which the V2 executor cannot read yet. As the layout reader did, a planned file scan whose filter the footer statistics prove false reads nothing. Signed-off-by: Nicholas Gates <nick@nickgates.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Engines that keep a V1/V2 switch while they move onto the Scan API, and benchmarks comparing the two executors, need each one as a DataSource. layout_reader_data_source() returns the layout-reader source that data_source() already falls back to, with the same footer statistics, and data_source() now calls it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Nicholas Gates <nick@nickgates.com>
This was referenced Nov 19, 2026
Contributor
Author
|
Superseded by #11665, which carries reworked versions of both commits (the V2 file source and the layout-reader source) on top of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Scan API (
DataSource) could only run Vortex files on the V1 layout reader; V2 was reachable only by engines that build itsScanBuilderthemselves (the DataFusion file opener and DuckDB).PlanDataSourceexposes anyScanInputas aDataSourcewhose partition runs onScanDriver, so a format only has to produce aScanInputto be scannable through the Scan API.VortexFile::data_source()now returns it, falling back toLayoutReaderDataSourcefor files whose layout tree has a list layout, which V2 cannot execute yet;plan_data_source()is always V2. As before, a scan whose filter the footer statistics prove false reads nothing.Behaviour change:
VortexFile::data_source()scans most files on V2. Its only in-tree caller is JNI's single-file source, which no benchmark suite exercises; multi-file sources (and soVortexTable) move in the last PR of this stack.Stacked on #11647.
🤖 Generated with Claude Code