Skip to content

Add a datafusion-bench flag for the Scan API table path - #11647

Closed
gatesn wants to merge 1 commit into
ngates/scan-io-segment-requestsfrom
ngates/scan-api-bench-flag
Closed

gatesn wants to merge 1 commit into
ngates/scan-io-segment-requestsfrom
ngates/scan-api-bench-flag

Conversation

@gatesn

@gatesn gatesn commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Benchmarking VortexTable, the Scan API table path, needed both --scan-v1 true and VORTEX_USE_SCAN_API=1, so it could not run in the same invocation as the listing table's V2 scan. --scan-api true registers Vortex tables through the Scan API whatever --scan-v1 says, and the environment variable keeps working. It lands first so the layers above it can be benchmarked against a baseline that has the same flag.

Stacked on #11623.

🤖 Generated with Claude Code

Benchmarking VortexTable needed both --scan-v1 true and
VORTEX_USE_SCAN_API=1, so it could not be compared with the listing table's
V2 scan in one run. --scan-api true registers Vortex tables through the Scan
API whatever --scan-v1 says; the environment variable keeps working.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn added the changelog/chore A trivial change label Nov 19, 2026
@gatesn
gatesn marked this pull request as ready for review November 19, 2026 19:01
@gatesn

gatesn commented Nov 20, 2026

Copy link
Copy Markdown
Contributor Author

Superseded: the same datafusion-bench flag now lands in the stack (#11666), and #11685 selects the integration as a benchmark axis.

@gatesn gatesn closed this Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant