Repository navigation
Add DecimalByteParts v2 and Widen to the unstable edition - #11615
Merged
Merged
Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
The unstable edition has no compatibility guarantee, so DecimalByteParts v2 can return while its between and aggregate kernels still decode to canonical form. Widen gets a wire ID in #11597, and the unstable edition lets writers emit it. Signed-off-by: Robert Kruszewski <github@robertk.io>
connortsui20
approved these changes
Nov 18, 2026
Merging this PR will not alter performance1 warning
Comparing Footnotes
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#11595 removed
vortex.decimal_byte_parts.v2from theunstableedition becausebetweenand aggregates decode to canonical form when lower parts exist. That is a performance gap, not a wire problem, andunstablehas no compatibility guarantee, so the encoding goes back in and the decompression kernels can follow.vortex.widengets a wire ID in #11597. Adding it tounstablelets writers that enforce editions emit integerWidenarrays and decimalWidenarrays over encoded children. Without it, those writes return an error.