Repository navigation
Keep only fastlanes.delta in the unstable edition - #11595
Merged
Merged
Conversation
bitpacked.v2, for.v2, decimal_byte_parts.v2, patched, union, the list layout, the SBBF bloom filter and sum_v2 leave the unstable edition and belong to no edition, so a writer that enforces editions no longer writes them. An audit found them not ready: blocked bitpacked.v2 and for.v2 have no slice, filter or take kernels, patched is gated by an environment variable, nothing produces union, the V2 scan cannot read the list layout, and the bloom filter is never used for pruning. The edition record is regenerated with `cargo run -p xtask -- generate-editions`. Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UeniBDnhofVptQwrj9sj7o
The unstable edition never freezes, so a test listing its members fails on every membership change. Keep only the invariant that enabling it never enables the vortex.all_* aggregates. Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UeniBDnhofVptQwrj9sj7o
Drop the added doc comments and the btrblocks comment change, leaving the one-line declaration change, the regenerated edition record, and the two tests that hardcoded the old members. Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UeniBDnhofVptQwrj9sj7o
The test hardcoded whether UNSTABLE permits decimal_byte_parts.v2, so it broke whenever the unstable edition changed. It now checks whether the session's enabled editions permit the v2 ID. Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UeniBDnhofVptQwrj9sj7o
robert3005
approved these changes
Nov 18, 2026
This was referenced Nov 18, 2026
robert3005
added a commit
that referenced
this pull request
Nov 19, 2026
#11595 removed `vortex.decimal_byte_parts.v2` from the `unstable` edition because `between` and aggregates decode to canonical form when lower parts exist. That is a performance gap, not a wire problem, and `unstable` has no compatibility guarantee, so the encoding goes back in and the decompression kernels can follow. `vortex.widen` gets a wire ID in #11597. Adding it to `unstable` lets writers that enforce editions emit integer `Widen` arrays and decimal `Widen` arrays over encoded children. Without it, those writes return an error. --------- Signed-off-by: Connor Tsui <connor.tsui20@gmail.com> Signed-off-by: Robert Kruszewski <github@robertk.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
unstableedition now contains onlyfastlanes.delta. Every other member leaves it and belongs to no edition, so a writer that enforces editions no longer writes them. An audit found the other members not ready:fastlanes.bitpacked.v2andfastlanes.for.v2: per-block bit widths and references have no slice, filter or take kernels, so those operations decode the whole array.vortex.patched: gated byVORTEX_EXPERIMENTAL_PATCHED_ARRAYrather than by the edition.vortex.union: nothing produces it.vortex.decimal_byte_parts.v2:betweenand aggregates fall back to canonical decoding when lower parts exist.vortex.listlayout: the V2 scan cannot read it.vortex.bloom_filter.sbbf: never used for pruning.vortex.sum_v2: partial invariants are not validated on read.Changes
vortex-edition/src/declarations/unstable/mod.rsnow lists onlyfastlanes.delta.vortex/editions/unstable/unstable2026.10.0.tomlis regenerated withcargo run -p xtask -- generate-editions.enabling_unstable_permits_only_persisted_aggregatesno longer lists the aggregatesunstableadds. It keeps its check that novortex.all_*aggregate is enabled.vortex-filedecimal edition test no longer expectsUNSTABLEto enabledecimal_byte_parts.v2.The fuzzers enable
UNSTABLE, so they stop writing the components that left it.Benchmark changes that enable
unstablein every benchmark are stacked on this PR in #11534.🤖 Generated with Claude Code
https://claude.ai/code/session_01UeniBDnhofVptQwrj9sj7o