Repository navigation
Reject DecimalByteParts v2 shapes that the writer never emits - #11596
Merged
Merged
Conversation
connortsui20
force-pushed
the
ct/dbp-v2-wire-contract
branch
from
November 18, 2026 15:02
43c8ef0 to
140018b
Compare
This was referenced Nov 18, 2026
connortsui20
marked this pull request as ready for review
November 18, 2026 19:57
connortsui20
enabled auto-merge (squash)
November 18, 2026 20:14
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
ct/dbp-v2-wire-contract
branch
from
November 18, 2026 20:46
140018b to
09e324b
Compare
connortsui20
requested review from
joseph-isaacs
and removed request for
mhk197
November 18, 2026 21:06
robert3005
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widenencoding for integers and decimals #10733No edition permits DecimalByteParts v2 yet, so its reader can still be narrowed to the shapes that the writer emits. Once v2 joins an edition, every shape the reader accepts stays legal. The writer never attaches node buffers, and it uses v1 for an array without lower parts, so v2 reads now reject both. Lower parts exist only above precision 18, where the logical MSP is
i64, so a v2 MSP can no longer be wider than its logical dtype. Only v1 files from earlier releases still take the checked copy of a wider MSP.Reading a v2 node without lower parts now fails. No writer produced that shape.
This change was prepared with AI assistance.