Skip to content

Reject DecimalByteParts v2 shapes that the writer never emits - #11596

Merged
connortsui20 merged 1 commit into
developfrom
ct/dbp-v2-wire-contract
Nov 18, 2026
Merged

connortsui20 merged 1 commit into
developfrom
ct/dbp-v2-wire-contract

Conversation

@connortsui20

@connortsui20 connortsui20 commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

No edition permits DecimalByteParts v2 yet, so its reader can still be narrowed to the shapes that the writer emits. Once v2 joins an edition, every shape the reader accepts stays legal. The writer never attaches node buffers, and it uses v1 for an array without lower parts, so v2 reads now reject both. Lower parts exist only above precision 18, where the logical MSP is i64, so a v2 MSP can no longer be wider than its logical dtype. Only v1 files from earlier releases still take the checked copy of a wider MSP.

Reading a v2 node without lower parts now fails. No writer produced that shape.

This change was prepared with AI assistance.

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20
connortsui20 force-pushed the ct/dbp-v2-wire-contract branch from 140018b to 09e324b Compare November 18, 2026 20:46
@connortsui20 connortsui20 changed the title Reject node buffers in DecimalByteParts v2 Reject DecimalByteParts v2 shapes that the writer never emits Nov 18, 2026
@connortsui20
connortsui20 requested review from joseph-isaacs and removed request for mhk197 November 18, 2026 21:06
@connortsui20
connortsui20 merged commit f3559d9 into develop Nov 18, 2026
79 checks passed
@connortsui20
connortsui20 deleted the ct/dbp-v2-wire-contract branch November 18, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants