Skip to content

Accept fastlanes 0.8.1's 'static bound on RLE decode - #11543

Merged
joseph-isaacs merged 1 commit into
developfrom
ji/fix-fastlanes-rle-static-bound
Nov 17, 2026
Merged

joseph-isaacs merged 1 commit into
developfrom
ji/fix-fastlanes-rle-static-bound

Conversation

@joseph-isaacs

Copy link
Copy Markdown
Contributor

Summary

The "Integration smoke tests (btrblocks golden, WASM, DuckDB S3)" job is failing on develop, and therefore on every open PR, in its wasm32 build step:

      Adding fastlanes v0.8.1 (requires Rust 1.91)
error[E0310]: the parameter type `I` may not live long enough
   --> encodings/fastlanes/src/rle/array/rle_decompress.rs:208:14
208 |     unsafe { V::decode_unchecked(chunk_values, chunk_indices, out) };
help: consider adding an explicit lifetime bound
195 |     I: Copy + Into<usize> + 'static,

wasm-test/ is outside the workspace and has no lockfile, so each run resolves the newest compatible crates. fastlanes 0.8.1 adds I: 'static to RLE::decode_unchecked, a breaking change in a patch release. The workspace Cargo.lock still pins 0.8.0, which is why the native jobs keep passing. The develop run at bdb4af5 still resolved 0.8.0 and passed; the runs from 295eef8 onward fail.

Changes

  • decode_chunk_checked gets the same bound: I: Copy + Into<usize> + 'static. Every index type passed to it is a primitive integer, so no caller changes are needed.

The workspace lockfile is untouched. This compiles against both fastlanes 0.8.0 and 0.8.1.

A possible follow-up: commit a lockfile for wasm-test/, or pin fastlanes, so an upstream release can't break this job like this again.

Checks

  • Reproduced the CI error locally: after cargo update -p fastlanes@0.8.0 --precise 0.8.1, cargo check -p vortex-fastlanes --lib fails with the same E0310.
  • With the fix and 0.8.1: cargo check -p vortex-fastlanes --all-targets passes.
  • With the fix and the locked 0.8.0: cargo clippy -p vortex-fastlanes --all-targets --all-features -- -D warnings passes.
  • With the fix: the failing CI step, cargo build --profile ci --target wasm32-wasip1 in wasm-test/, succeeds and produces wasm-test.wasm. That build resolved fastlanes 0.8.1.

Generated by Claude Code

fastlanes 0.8.1 adds `I: 'static` to `RLE::decode_unchecked`. The
workspace lockfile still pins 0.8.0, but `wasm-test/` has no lockfile
and resolves 0.8.1, so its wasm32 builds (the integration smoke tests)
fail with E0310 in `decode_chunk_checked`. Add the same bound there;
every index type is a primitive, so callers are unaffected, and it
builds against both 0.8.0 and 0.8.1.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UeniBAvrcuvbZMgsM2XrTM
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@0ax1

0ax1 commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

yes, thank you

@joseph-isaacs
joseph-isaacs merged commit 7737dbb into develop Nov 17, 2026
103 checks passed
@joseph-isaacs
joseph-isaacs deleted the ji/fix-fastlanes-rle-static-bound branch November 17, 2026 13:55
joseph-isaacs added a commit that referenced this pull request Nov 17, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs added a commit that referenced this pull request Nov 17, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs added a commit that referenced this pull request Nov 17, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs added a commit that referenced this pull request Nov 17, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs added a commit that referenced this pull request Nov 17, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs added a commit that referenced this pull request Nov 17, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs added a commit that referenced this pull request Nov 17, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs added a commit that referenced this pull request Nov 17, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants