Repository navigation
Accept fastlanes 0.8.1's 'static bound on RLE decode - #11543
Merged
Merged
Conversation
fastlanes 0.8.1 adds `I: 'static` to `RLE::decode_unchecked`. The workspace lockfile still pins 0.8.0, but `wasm-test/` has no lockfile and resolves 0.8.1, so its wasm32 builds (the integration smoke tests) fail with E0310 in `decode_chunk_checked`. Add the same bound there; every index type is a primitive, so callers are unaffected, and it builds against both 0.8.0 and 0.8.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UeniBAvrcuvbZMgsM2XrTM Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
robert3005
approved these changes
Nov 17, 2026
Contributor
|
yes, thank you |
joseph-isaacs
added a commit
that referenced
this pull request
Nov 17, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
added a commit
that referenced
this pull request
Nov 17, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
added a commit
that referenced
this pull request
Nov 17, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
added a commit
that referenced
this pull request
Nov 17, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
added a commit
that referenced
this pull request
Nov 17, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
added a commit
that referenced
this pull request
Nov 17, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
added a commit
that referenced
this pull request
Nov 17, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
added a commit
that referenced
this pull request
Nov 17, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Integration smoke tests (btrblocks golden, WASM, DuckDB S3)" job is failing on
develop, and therefore on every open PR, in its wasm32 build step:wasm-test/is outside the workspace and has no lockfile, so each run resolves the newest compatible crates.fastlanes0.8.1 addsI: 'statictoRLE::decode_unchecked, a breaking change in a patch release. The workspaceCargo.lockstill pins 0.8.0, which is why the native jobs keep passing. Thedeveloprun at bdb4af5 still resolved 0.8.0 and passed; the runs from 295eef8 onward fail.Changes
decode_chunk_checkedgets the same bound:I: Copy + Into<usize> + 'static. Every index type passed to it is a primitive integer, so no caller changes are needed.The workspace lockfile is untouched. This compiles against both
fastlanes0.8.0 and 0.8.1.A possible follow-up: commit a lockfile for
wasm-test/, or pinfastlanes, so an upstream release can't break this job like this again.Checks
cargo update -p fastlanes@0.8.0 --precise 0.8.1,cargo check -p vortex-fastlanes --libfails with the same E0310.cargo check -p vortex-fastlanes --all-targetspasses.cargo clippy -p vortex-fastlanes --all-targets --all-features -- -D warningspasses.cargo build --profile ci --target wasm32-wasip1inwasm-test/, succeeds and produceswasm-test.wasm. That build resolvedfastlanes0.8.1.Generated by Claude Code