Repository navigation
Move fastlanes kernel logic out of dispatch macros - #11532
Merged
Merged
Conversation
cargo-mutants does not mutate code inside macro invocations, so logic written in a `match_each_*!` body is never mutation tested. Keep those calls as thin dispatches and move the logic into generic functions, which monomorphize to the same code: - `block_offsets_typed`: the block offset accumulation loop of `block_offsets_from_widths`. - `has_negative_min`: the negative-minimum check of `ensure_non_negative_integers`, whose `unused_comparisons` and `absurd_extreme_comparisons` expectation no longer applies. - `block_boundaries`: reading a block's host offsets in `unpack_single_blocked`. - `set_patch_values`: the patch loop of `apply_patches_to_uninit_range`. - `set_patch_bits`: the identical patch loops of `constant_result` and `stream_compare_fused`, now shared. - `stream_patched_predicate`: the patched chunk walk of `stream_predicate`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UeniBAvrcuvbZMgsM2XrTM Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
cargo-mutants does not mutate code inside macro invocations, so logic written in a `match_each_*!` body is never mutation tested. Keep those calls as thin dispatches and move the logic into generic functions, which monomorphize to the same code: - `patches_in_positions`: the patch position filter of Delta's `chunk_patches`. - `all_equal` and `all_equal_to`: the value comparisons of Delta's `all_valid_is_constant`. - `set_patch_values`: the patch loop of FoR's `apply_patches`. - `widen_offsets`: the value-index offset widening of `rle_decompress`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UeniBAvrcuvbZMgsM2XrTM Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
marked this pull request as ready for review
November 17, 2026 12:56
joseph-isaacs
enabled auto-merge (squash)
November 17, 2026 13:27
Contributor
Author
|
CI status: the failing "Integration smoke tests" job fails on Generated by Claude Code |
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
robert3005
approved these changes
Nov 17, 2026
connortsui20
added a commit
that referenced
this pull request
Nov 18, 2026
`cargo-mutants` skips macro bodies, so it cannot mutate predicates and loops inside type dispatch. Generic helpers make that logic available to mutation testing and preserve static dispatch. This follows the approach in #11528 and #11532. This change was prepared with assistance from Codex. --------- Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo-mutants can't mutate code inside macros, so logic in fastlanes'
match_each_*!bodies was never mutation tested. This moves it into generic helpers across the bitpacking, delta, FoR and RLE kernels.🤖 Generated with Claude Code
https://claude.ai/code/session_01UeniBAvrcuvbZMgsM2XrTM