Repository navigation
Find the DuckDB cache by cargo's build directory, not parent count - #11463
joseph-isaacs wants to merge 1 commit into
Conversation
Rust 1.100's cargo moved build script output from `<profile>/build/<pkg>-<hash>/out` to `<profile>/build/<pkg>/<hash>/out`. `duckdb_cache_root` went up exactly two directories from `OUT_DIR`, so the cache moved into `build/vortex-duckdb/vortex-duckdb-cache`. The SQL benchmark workflow still uploads `libduckdb.so` from `build/vortex-duckdb-cache`, so the glob matched nothing and every DuckDB benchmark failed to load the library. Walk up to the `build` directory instead, which works with both layouts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UeniB9qpUTjRzFTWu15i47 Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Merging this PR will degrade performance by 12.41%2 warnings
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
|
We need to change how we find duckdb, this is not any better than develop |
Summary
Since the Rust 1.100 upgrade (#11446), every DuckDB SQL benchmark fails at startup, on
developand on PRs:Rust 1.100's cargo moved build script output one level deeper:
OUT_DIR<profile>/build/<pkg>-<hash>/out<profile>/build/<pkg>/<hash>/outduckdb_cache_rootwent up exactly two directories fromOUT_DIR, so the DuckDB cache moved frombuild/vortex-duckdb-cachetobuild/vortex-duckdb/vortex-duckdb-cache.sql-bench-matrix.ymlstill uploadstarget/release_debug/build/vortex-duckdb-cache/duckdb-lib-*-prebuilt/libduckdb.so. Withif-no-files-found: warn, the build job quietly uploaded 4 files instead of 5, and the bench machines never got the library thatduckdb-bench's rpath points at. See the build and bench jobs of run 43458968304.Changes
vortex-duckdb/build.rs:duckdb_cache_rootwalks up fromOUT_DIRto cargo'sbuilddirectory instead of counting parents. The cache is back at<profile>/build/vortex-duckdb-cachewith both layouts, which is where the workflow uploads it from, so the workflow needs no change.Checked by running the new function in a build script under 1.99.0 and 1.100.0. Both resolve to
target/release/build/vortex-duckdb-cache. Abench-sqlrun on this PR would confirm the benchmark artifact includeslibduckdb.soagain.Generated by Claude Code