Skip to content

Find the DuckDB cache by cargo's build directory, not parent count - #11463

Closed
joseph-isaacs wants to merge 1 commit into
developfrom
ji/duckdb-cache-root
Closed

joseph-isaacs wants to merge 1 commit into
developfrom
ji/duckdb-cache-root

Conversation

@joseph-isaacs

Copy link
Copy Markdown
Contributor

Summary

Since the Rust 1.100 upgrade (#11446), every DuckDB SQL benchmark fails at startup, on develop and on PRs:

duckdb-bench: error while loading shared libraries: libduckdb.so: cannot open shared object file

Rust 1.100's cargo moved build script output one level deeper:

Toolchain OUT_DIR
1.99 <profile>/build/<pkg>-<hash>/out
1.100 <profile>/build/<pkg>/<hash>/out

duckdb_cache_root went up exactly two directories from OUT_DIR, so the DuckDB cache moved from build/vortex-duckdb-cache to build/vortex-duckdb/vortex-duckdb-cache. sql-bench-matrix.yml still uploads target/release_debug/build/vortex-duckdb-cache/duckdb-lib-*-prebuilt/libduckdb.so. With if-no-files-found: warn, the build job quietly uploaded 4 files instead of 5, and the bench machines never got the library that duckdb-bench's rpath points at. See the build and bench jobs of run 43458968304.

Changes

  • vortex-duckdb/build.rs: duckdb_cache_root walks up from OUT_DIR to cargo's build directory instead of counting parents. The cache is back at <profile>/build/vortex-duckdb-cache with both layouts, which is where the workflow uploads it from, so the workflow needs no change.

Checked by running the new function in a build script under 1.99.0 and 1.100.0. Both resolve to target/release/build/vortex-duckdb-cache. A bench-sql run on this PR would confirm the benchmark artifact includes libduckdb.so again.


Generated by Claude Code

Rust 1.100's cargo moved build script output from
`<profile>/build/<pkg>-<hash>/out` to `<profile>/build/<pkg>/<hash>/out`.
`duckdb_cache_root` went up exactly two directories from `OUT_DIR`, so
the cache moved into `build/vortex-duckdb/vortex-duckdb-cache`. The SQL
benchmark workflow still uploads `libduckdb.so` from
`build/vortex-duckdb-cache`, so the glob matched nothing and every
DuckDB benchmark failed to load the library.

Walk up to the `build` directory instead, which works with both layouts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UeniB9qpUTjRzFTWu15i47
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@codspeed

codspeed Bot commented Nov 13, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 12.41%

2 warnings

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ 1 benchmark is dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

❌ 1 regressed benchmark
✅ 1935 untouched benchmarks
⏩ 50 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Walltime random_rotating_avx2[(0.9, 0.9, "self_90pct_mask_90pct")] 8.3 µs 9.4 µs -12.41%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ji/duckdb-cache-root (ca749ff) with develop (f5d4d6d)

Open in CodSpeed

Footnotes

  1. 50 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@robert3005 robert3005 added the changelog/skip Do not list PR in the changelog label Nov 13, 2026
@robert3005

Copy link
Copy Markdown
Contributor

We need to change how we find duckdb, this is not any better than develop

@robert3005 robert3005 closed this Nov 18, 2026
@robert3005
robert3005 deleted the ji/duckdb-cache-root branch November 18, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/skip Do not list PR in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants