Repository navigation
Upgrade Rust to 1.100.0 and nightly to 2026-11-13 - #11446
Conversation
Set the stable toolchain to 1.100.0 and NIGHTLY_TOOLCHAIN to nightly-2026-11-13 in all workflows. Fix the new clippy and cargo findings: - Remove redundant clones that clippy 1.100 reports. - Keep both values alive in test_clone_logical_type, so the test still checks the FFI Clone. - Remove the unused arrow-arith workspace dependency. - Add vortex-elias-fano to vortex, re-export it as vortex::encodings::elias_fano and register it in the default session. - Check the target OS, not the host OS, in the datafusion-bench build script. - Make all vortex-web-wasm dependencies wasm32-only, because the library is empty on other targets. Signed-off-by: Robert Kruszewski <github@robertk.io>
Merging this PR will degrade performance by 5.14%3 warnings
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
Cargo 1.100 makes the per-unit build-dir layout the default. In this layout cargo passes rustc one `-L dependency=` for each crate. On Windows the vortex-layout command line is 45 KB, which is more than the 32 KB limit. Cargo then uses an argfile, but sccache expands it and fails with os error 206 (mozilla/sccache#2397). Keep the old layout in the two Windows jobs that use sccache. The new layout puts build script stdout in `run/stdout` next to the `out` directory. Read it from there in the CMake integration test. Signed-off-by: Robert Kruszewski <github@robertk.io>
## Summary Every SQL benchmark that runs DuckDB fails with: ``` duckdb-bench: error while loading shared libraries: libduckdb.so: cannot open shared object file: No such file or directory ``` This started with the Rust 1.100 upgrade (#11446). Rust 1.100's cargo moved build script output from `build/<pkg>-<hash>/out` to `build/<pkg>/<hash>/out`. `vortex-duckdb/build.rs` keeps its DuckDB cache two levels above `OUT_DIR`, so the library moved: - before: `target/release_debug/build/vortex-duckdb-cache/duckdb-lib-*/libduckdb.so` - now: `target/release_debug/build/vortex-duckdb/vortex-duckdb-cache/duckdb-lib-*/libduckdb.so` The artifact path still names the old location. upload-artifact leaves out an unmatched path without an error, so the bench jobs get `duckdb-bench` without the library that its absolute rpath points to. ## Changes `sql-bench-matrix.yml`, build job: - The artifact path matches the library at any depth under `target/release_debug/build`, so it works with both layouts. It also matches a DuckDB built from source as well as a prebuilt one. upload-artifact still roots the artifact at `target/release_debug`, so the library unpacks at the path the rpath expects. - A new step fails the build job if `libduckdb.so` is missing. A missing library now stops the build, instead of letting every DuckDB benchmark fail later. A sturdier fix would be for `vortex-duckdb/build.rs` to stop deriving its cache location from `OUT_DIR`, since cargo can change that layout again. I kept this PR to the workflow. Checks: - `yamllint --strict -c .yamllint.yaml` passes. - With cargo 1.100, a local build script prints `OUT_DIR=.../target/debug/build/<pkg>/<hash>/out`. - I ran the same fix, as a tar-based packaging step, on #11450. There FineWeb, TPC-H SF=1 and SF=10, TPC-DS SF=1 and SF=10, ClickBench and TPC-H on S3 all finished with DuckDB results. Before the fix they failed with the error above, on that PR and on other branches. --- --- _Generated by [Claude Code](https://claude.ai/code/session_01UeniBAMeLpyH1yASJhrK1N)_ Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Summary
rust-toolchain.tomlto1.100.0.NIGHTLY_TOOLCHAINtonightly-2026-11-13in all 12 workflows that pin it. The new rustfmt makes no changes to the code.Clippy 1.100 (
redundant_clone)vortex-array,vortex-fastlanes,vortex-fuzz,vortex-cuda,vortex-sqllogictestandxtask.vortex-duckdb:test_clone_logical_typetests the FFIClone. Keep the clone and keep the original value alive, and check the type of both values.Cargo 1.100 lints
unused_workspace_dependencies:arrow-arith.vortex-elias-fanotovortex, re-export it asvortex::encodings::elias_fanoand register it inVortexSession::default(). It is not in any file edition yet.unused_dependencies:datafusion-bench/build.rschecksCARGO_CFG_TARGET_OSand not#[cfg(target_os)], which reads the host OS. The link argument is for the target.vortex-web-wasmputs all its dependencies undercfg(target_arch = "wasm32"), because the library is empty on other targets.