Skip to content

Upgrade Rust to 1.100.0 and nightly to 2026-11-13 - #11446

Merged
robert3005 merged 2 commits into
developfrom
rk/rust-1.100
Nov 13, 2026
Merged

robert3005 merged 2 commits into
developfrom
rk/rust-1.100

Conversation

@robert3005

@robert3005 robert3005 commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Set the stable toolchain in rust-toolchain.toml to 1.100.0.
  • Set NIGHTLY_TOOLCHAIN to nightly-2026-11-13 in all 12 workflows that pin it. The new rustfmt makes no changes to the code.

Clippy 1.100 (redundant_clone)

  • Remove redundant clones in vortex-array, vortex-fastlanes, vortex-fuzz, vortex-cuda, vortex-sqllogictest and xtask.
  • vortex-duckdb: test_clone_logical_type tests the FFI Clone. Keep the clone and keep the original value alive, and check the type of both values.

Cargo 1.100 lints

  • unused_workspace_dependencies:
    • Remove arrow-arith.
    • Add vortex-elias-fano to vortex, re-export it as vortex::encodings::elias_fano and register it in VortexSession::default(). It is not in any file edition yet.
  • unused_dependencies:
    • datafusion-bench/build.rs checks CARGO_CFG_TARGET_OS and not #[cfg(target_os)], which reads the host OS. The link argument is for the target.
    • vortex-web-wasm puts all its dependencies under cfg(target_arch = "wasm32"), because the library is empty on other targets.

Set the stable toolchain to 1.100.0 and NIGHTLY_TOOLCHAIN to
nightly-2026-11-13 in all workflows.

Fix the new clippy and cargo findings:

- Remove redundant clones that clippy 1.100 reports.
- Keep both values alive in test_clone_logical_type, so the test
  still checks the FFI Clone.
- Remove the unused arrow-arith workspace dependency.
- Add vortex-elias-fano to vortex, re-export it as
  vortex::encodings::elias_fano and register it in the default session.
- Check the target OS, not the host OS, in the datafusion-bench build
  script.
- Make all vortex-web-wasm dependencies wasm32-only, because the
  library is empty on other targets.

Signed-off-by: Robert Kruszewski <github@robertk.io>
@codspeed

codspeed Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 5.14%

3 warnings

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ 1 benchmark is dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 6 benchmarks with a significant change ran in a different software environment

Their base and head results were measured with a different OS or toolchain, such as compiler, runtime or library versions, so the changes might come from this difference rather than from the code. Open an affected benchmark to see what changed.

See affected benchmarks

⚡ 2 improved benchmarks
❌ 4 regressed benchmarks
✅ 1977 untouched benchmarks
⏩ 3 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ CPU Simulation compare[1] 47.9 µs 57.6 µs -16.83%
❌ Walltime random_rotating_avx2[(0.5, 0.02, "self_50pct_mask_2pct")] 49 µs 55.2 µs -11.14%
❌ CPU Simulation new_raw_prim_test_between[i32, 16384] 120.1 µs 134.8 µs -10.95%
❌ Walltime cuda/bitpacked_u8/unpack/3bw[100M] 300.5 µs 334.5 µs -10.15%
⚡ CPU Simulation test_repeated_scan_scalar_at[int_float] 317.2 µs 283.4 µs +11.93%
⚡ Walltime starts_with_avx512[64, VarBinView] 127.4 µs 115.7 µs +10.07%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/rust-1.100 (2b50ef3) with develop (eacb353)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Cargo 1.100 makes the per-unit build-dir layout the default. In this
layout cargo passes rustc one `-L dependency=` for each crate. On
Windows the vortex-layout command line is 45 KB, which is more than the
32 KB limit. Cargo then uses an argfile, but sccache expands it and
fails with os error 206 (mozilla/sccache#2397). Keep the old layout in
the two Windows jobs that use sccache.

The new layout puts build script stdout in `run/stdout` next to the
`out` directory. Read it from there in the CMake integration test.

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005
robert3005 merged commit a1a2143 into develop Nov 13, 2026
77 of 78 checks passed
@robert3005
robert3005 deleted the rk/rust-1.100 branch November 13, 2026 15:27
joseph-isaacs added a commit that referenced this pull request Nov 13, 2026
## Summary

Every SQL benchmark that runs DuckDB fails with:

```
duckdb-bench: error while loading shared libraries: libduckdb.so: cannot open shared object file: No such file or directory
```

This started with the Rust 1.100 upgrade (#11446). Rust 1.100's cargo
moved build script output from `build/<pkg>-<hash>/out` to
`build/<pkg>/<hash>/out`. `vortex-duckdb/build.rs` keeps its DuckDB
cache two levels above `OUT_DIR`, so the library moved:

- before:
`target/release_debug/build/vortex-duckdb-cache/duckdb-lib-*/libduckdb.so`
- now:
`target/release_debug/build/vortex-duckdb/vortex-duckdb-cache/duckdb-lib-*/libduckdb.so`

The artifact path still names the old location. upload-artifact leaves
out an unmatched path without an error, so the bench jobs get
`duckdb-bench` without the library that its absolute rpath points to.

## Changes

`sql-bench-matrix.yml`, build job:
- The artifact path matches the library at any depth under
`target/release_debug/build`, so it works with both layouts. It also
matches a DuckDB built from source as well as a prebuilt one.
upload-artifact still roots the artifact at `target/release_debug`, so
the library unpacks at the path the rpath expects.
- A new step fails the build job if `libduckdb.so` is missing. A missing
library now stops the build, instead of letting every DuckDB benchmark
fail later.

A sturdier fix would be for `vortex-duckdb/build.rs` to stop deriving
its cache location from `OUT_DIR`, since cargo can change that layout
again. I kept this PR to the workflow.

Checks:
- `yamllint --strict -c .yamllint.yaml` passes.
- With cargo 1.100, a local build script prints
`OUT_DIR=.../target/debug/build/<pkg>/<hash>/out`.
- I ran the same fix, as a tar-based packaging step, on
#11450. There FineWeb, TPC-H SF=1 and SF=10, TPC-DS
SF=1 and SF=10, ClickBench and TPC-H on S3 all finished with DuckDB
results. Before the fix they failed with the error above, on that PR and
on other branches.

---

---
_Generated by [Claude
Code](https://claude.ai/code/session_01UeniBAMeLpyH1yASJhrK1N)_

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

This branch was successfully deployed

1 active deployment
vercel-docs — 2b50ef37 Deployed Nov 13, 2026 by robert3005 via Publish preview / Deploy #9710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants