Repository navigation
Conversation
Extract the reusable test-only helper from c91e73493b so independent encoding migrations can carry the same prerequisite commit. Source-commit: c91e73493b592c0436b08fa775cb594dc8afd955 Signed-off-by: Gunther Xing <jiengup@gmail.com>
Signed-off-by: Gunther Xing <jiengup@gmail.com> (cherry picked from commit 835220d0a0360bbf51f8b53a1b2c4d7e00b07fcc) Signed-off-by: Gunther Xing <jiengup@gmail.com>
Signed-off-by: Gunther Xing <jiengup@gmail.com> (cherry picked from commit 725a9190cbd837f5f4f2445bd682b2052e198eb0) Signed-off-by: Gunther Xing <jiengup@gmail.com>
Keep only this branch's portions of the original lint, session, and benchmark follow-ups, including the matching manifest/lockfile changes. Source-commits: 4c49e477e2, 8b1811ff84, 4405aa8187 Signed-off-by: Gunther Xing <jiengup@gmail.com>
Signed-off-by: Gunther Xing <jiengup@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OperationsVTable::scalar_attoprobe_scalar#9971OperationsVTable::scalar_atcannot retain preparation between row reads. The probe API introduced in #9843 retains encoding state, validity, and child probes across repeated reads.This PR migrates 2 implementations: Patched, PiecewiseSequence.
scalar_atremains a one-off probe compatibility shim.Verification
The following checks passed locally before rebasing onto
20cc6e2aef.cargo nextest run --cargo-profile ci --locked -p vortex-array --all-features --no-fail-fast— 4,712 passed, 1 skipped.cargo test --profile ci --locked -p vortex-array --all-features --doc --no-fail-fast— 84 passed, 21 ignored.cargo +nightly-2026-09-10 fmt -p vortex-array --check— passed.cargo clippy --profile ci --locked -p vortex-array --all-targets --all-features -- -D warnings— passed.cargo benchruns — the benchmark target completed successfully.Comparison to baseline
Measured on a development machine (macOS with Apple Silicon); not representative of production performance.
cargo bench -p <crate> --bench <name> -- --min-time 0.1 --sample-count 15. Values are Divan medians in microseconds per iteration, with one retained probe per iteration.AI Usage
GPT-6-Sol implemented the changes with Codex. The human reviewed all the code and can explain every line of it. Benchmark results and the origin/develop comparisons are done by Codex.