Repository navigation
Conversation
Merging this PR will regress 1 benchmark3 warnings
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
6cacf75 to
c4c5786
Compare
Extract the reusable test-only helper from c91e73493b so independent encoding migrations can carry the same prerequisite commit. Source-commit: c91e73493b592c0436b08fa775cb594dc8afd955 Signed-off-by: Gunther Xing <jiengup@gmail.com>
Signed-off-by: Gunther Xing <jiengup@gmail.com> (cherry picked from commit c91e73493b592c0436b08fa775cb594dc8afd955) Signed-off-by: Gunther Xing <jiengup@gmail.com>
Keep only this branch's portions of the original lint, session, and benchmark follow-ups, including the matching manifest/lockfile changes. Source-commits: 4c49e477e2, 8b1811ff84, 4405aa8187 Signed-off-by: Gunther Xing <jiengup@gmail.com>
Signed-off-by: Gunther Xing <jiengup@gmail.com>
Signed-off-by: Gunther Xing <jiengup@gmail.com>
c4c5786 to
2b5bda2
Compare
Summary
OperationsVTable::scalar_attoprobe_scalar#9971OperationsVTable::scalar_atcannot retain preparation between row reads. The probe API introduced in #9843 retains encoding state, validity, and child probes across repeated reads.This PR migrates 10 implementations: Filter, Interleave, ScalarFnValidity, Union, Variant, FixedSizeList, List, ListView, VarBin, DecimalByteParts.
ProbeState = (); validity and child probes are retained through stable slots.scalar_atremains a one-off probe compatibility shim.Verification
The following checks passed locally before rebasing onto
20cc6e2aef.cargo nextest run --cargo-profile ci --locked -p vortex-array -p vortex-decimal-byte-parts --all-features --no-fail-fast— 5,001 passed, 1 skipped.cargo test --profile ci --locked -p vortex-array -p vortex-decimal-byte-parts --all-features --doc --no-fail-fast— 84 passed, 21 ignored.cargo +nightly-2026-09-10 fmt -p vortex-array -p vortex-decimal-byte-parts --check— passed.cargo clippy --profile ci --locked -p vortex-array -p vortex-decimal-byte-parts --all-targets --all-features -- -D warnings— passed.cargo benchruns — all 2 benchmark targets completed successfully.Comparison to baseline
Measured on a development machine (macOS with Apple Silicon); not representative of production performance.
Historical comparison of
d270200d65with the cumulative migration treecf5a9da2aa, using Rust 1.99.1 and the same benchmark sources, manifests, and lockfile. These are cumulative-branch measurements, not a comparison against this PR's current base.cargo bench -p <crate> --bench <name> -- --min-time 0.1 --sample-count 15. Values are Divan medians in microseconds per iteration, with one retained probe per iteration.The Variant retained-read fixture regressed by 6.8%; its one-off reads improved from 7.332 to 6.541 µs. The VarBin result includes the direct Primitive-offset path.
AI Usage
GPT-6-Sol implemented the changes with Codex. The human reviewed all the code and can explain every line of it. Benchmark results and the origin/develop comparisons are done by Codex.