Repository navigation
Conversation
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
This was referenced Nov 2, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a grouped
SumV2kernel for sparse elements. Each list sums its patches as a group of the patch values, plus the fill times its uncovered elements, instead of decoding the sparse array. statpopgen'sGTcomparisons produce sparse bools.Changes
SparseGroupedSumV2Kernelinvortex-sparse, registered byinitialize.SumV2GroupPartialsbecomes public and gainsadd_repeatedfor the fill.Benchmarks
Time vs the PR below, by average list length.
sparse_bool_sumchunked_sparse_bool_sumTesting
grouped_sum_matches_decoded: 5 sparse cases against summing the decoded array.cargo clippy -p vortex-array -p vortex-sparse --all-targets --all-features -- -D warningsand thevortex-sparsesum tests pass.Follow-up