Repository navigation
Conversation
Merging this PR will regress 2 benchmarks2 warnings
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes |
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
mhk197
force-pushed
the
mk/grouped-sum-kernels
branch
from
November 2, 2026 17:24
515fda4 to
70b11ed
Compare
SumV2 kernels for bool, chunked, sparse and run-end list elementsSumV2 kernels for bool and chunked list elements
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list_sumruns throughGroupedAccumulator, which only has a groupedSumV2kernel for primitive elements. Bool elements fall back to summing one list at a time, and chunked elements are concatenated first. This adds groupedSumV2kernels for bool and chunked elements. The sparse (#11106) and run-end (#11107) kernels stack on top.Changes
Bool: counts each list's valid set bits withcount_range.Chunked: splits each list across the chunks it spans, sums each chunk's parts with that chunk's grouped kernel, and skips chunks no list touches.SumV2GroupPartials(module-private): adds per-part partials withSumV2's overflow and empty rules.Benchmarks
list_sumbenches from the PR below, time vs develop, by average list length.bool_sumchunked_bool_sumchunked_i32_sumTesting
grouped_kernels_match_per_group_sums: bool, chunked, nested-chunk and overflow cases against a per-list scalarsum_v2.cargo clippy -p vortex-array --all-targets --all-features -- -D warnings,rustfmt(nightly-2026-09-10) and thesum_v2/list_sumtests pass.Follow-up