Repository navigation
Conversation
aca3c1e to
aa42a70
Compare
aa42a70 to
cb0591b
Compare
ee3adca to
33b6f30
Compare
Merging this PR will not alter performance1 warning
Comparing |
ce57a1c to
aad6a9d
Compare
|
@claude review |
|
Claude finished @danking's task in 1m 7s —— View job Review: PCO selection contract tests
The tests are well-scoped and test-only. They cover nested slices, repeated and out-of-order indices, nullable indices, stride-0 and zero-length 1. The expected values are not independent of the code under test (main point)The PR body says the results are checked against "independent PrimitiveArray results". But PCO has no The protection only kicks in once a later PR adds a PCO-specific take path. That is the stated goal, so it's fine, but the small cases are cheap to pin down as literals: // invalid_indices_under_nulls_are_ignored
assert_arrays_eq!(
compressed.take(indices)?,
PrimitiveArray::from_option_iter([Some(11i32), None, None, Some(33)]),
&mut ctx
);The same applies to the 8-element take in 2. No test crosses a PCO chunk boundary
3. Smaller points
CodSpeedThe reported changes are ChecksI did not run any builds or tests. Following AGENTS.md, verification is left to you. The narrow commands would be |
41a0e9e to
39dadb2
Compare
|
@claude review |
|
Claude finished @danking's task in 54s —— View job Review: PCO selection contract tests (second pass, through 39dadb2)
The new commits fix the two main points from my last review. The expected values are now written out as literals, and there is a test that crosses a chunk boundary. I checked every hand-written expected value and found no errors. All 6 commits have Expected values I checked
1. No nullable input crosses a chunk boundary (main remaining gap)
Suggested test: a nullable input of about 400k rows with roughly ⅓ nulls, so the dense boundary lands at a logical row that is not a round number. Select indices on both sides of the row whose dense index is 262 143 / 262 144, and add a slice and a few probes across that row. The expected values stay easy to write by hand if values and validity are both formulas of 2. Smaller points
CodSpeedThe PR adds only ChecksI didn't run any builds or tests; AGENTS.md leaves that to you. The narrowest checks are |
…rnels Signed-off-by: Daniel King <dan@spiraldb.com>
…change Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
…blic APIs Signed-off-by: Daniel King <dan@spiraldb.com>
f56bceb to
28e1ea2
Compare
|
Addressed the remaining public coverage gaps in 28e1ea2: add a nullable input whose dense-value chunk boundary falls between logical rows 393215 and 393217, with literal take expectations plus sliced and retained-probe checks across the boundary. Compact-range cases now cover nullable/non-nullable sources, sliced sources, and multiple stride-one ranges crossing mixed-validity pages. The float comparison explains why it checks NaN payloads and signed-zero bits; the RunEnd-validity test explains its placement in vortex-file. These stay in the test-only second PR and inspect public values rather than wire/index internals. The later take PR updates these sessions to initialize so they exercise the registered kernel. Local independent source review passed, including the literal oracle and this PR's pre-implementation registration API; tests have not been rerun. |
|
This PR has been marked as stale because it has been open for 14 days with no activity. Please comment or remove the stale label if you wish to keep it active, otherwise it will be closed in 7 days |
Add blackbox tests for PCO selection, slicing, scalar probes, nulls, value ordering, and file compatibility. The tests pass against the existing implementation and establish the public behavior that subsequent page-index optimizations must preserve.