Repository navigation
Conversation
9f794ae to
b8db1cd
Compare
b8db1cd to
e7b55d9
Compare
e7b55d9 to
e6398b0
Compare
e6398b0 to
7b12001
Compare
3f4a1bf to
6b72351
Compare
Merging this PR will regress 4 benchmarks4 warnings, 1 note
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
6b72351 to
31e5075
Compare
31e5075 to
1abac5d
Compare
|
@claude review |
|
Claude finished @danking's task in 1m 2s —— View job Review: Use PCO logical-page indexes for retained scalar probes
I found no correctness bugs. The refactor removes about 130 lines of duplicated page/rank/decoder code from Correctness checks that passed
Points to consider
Tests
ChecksPer the repo's |
1abac5d to
774c145
Compare
774c145 to
6e3f22a
Compare
0951998 to
2957a2d
Compare
7da4edd to
029cd51
Compare
029cd51 to
2256676
Compare
59cd43c to
379dc7f
Compare
379dc7f to
59ef310
Compare
e71fe5e to
d1e1506
Compare
5789b8c to
6439b77
Compare
6439b77 to
bdbef6e
Compare
bdbef6e to
e314deb
Compare
e314deb to
c1375bb
Compare
c1375bb to
580c132
Compare
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
|
Reviewed the probe feedback against 95b18de. The earlier one-off rank-table allocation and redundant all-null bounds check were already removed; the current optimization is indexed-file-only and leaves legacy probes on their original path. The new public nullable chunk-crossing/sliced retained-probe case lives in PR10825. Updated the probe-state documentation to state its one-array ownership and retained validity/rank memory. A whole-index consistency scan or new corrupted-metadata error contract was not added, following Daniel's explicit validation policy. The performance regressions remain disclosed and unacknowledged; source review alone is not a matched timing rerun. Local independent source review passed before pushing; no builds/tests were run. |
|
This PR has been marked as stale because it has been open for 14 days with no activity. Please comment or remove the stale label if you wish to keep it active, otherwise it will be closed in 7 days |
Use the logical-row page index to locate scalar probes and cache prepared or decoded pages across probes. This avoids whole-array decoding for sparse access while preserving the existing probe path for files without the index. Cached memory grows with touched pages, and CodSpeed reports retained-probe and scalar-access regressions that remain unresolved.