Skip to content

Pin cc to 1.8.0 to fix the Windows CI build - #10815

Merged
robert3005 merged 2 commits into
developfrom
rk/pin-cc-1.8
Oct 26, 2026
Merged

robert3005 merged 2 commits into
developfrom
rk/pin-cc-1.8

Conversation

@robert3005

@robert3005 robert3005 commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

#10810 updated cc from 1.8.0 to 1.10.0. After that, Rust tests (windows-x64) fails in the libmimalloc-sys build script:

c1xx: fatal error C1083: Cannot open source file: '/WX-': No such file or directory
error: failed to run custom build command for `libmimalloc-sys v0.1.49`

Cause:

  1. Starting with cc 1.9.0, cc runs cl.exe through the RUSTC_WRAPPER fallback. CI sets RUSTC_WRAPPER=sccache. cc 1.8.0 runs cl.exe directly.
  2. For .cc sources, cc passes -Tp <file> as two separate arguments. sccache 0.18.0 does not know -Tp, so it treats it as an unknown flag.
  3. The sccache preprocess command adds /WX- before the input file. cl.exe then reads /WX- as the -Tp source file.

robert3005 and others added 2 commits October 26, 2026 16:46
cc 1.9 and later run cl.exe through RUSTC_WRAPPER (sccache). sccache 0.18
does not parse `-Tp <file>` and puts `/WX-` before the file in its
preprocess command, so cl.exe reads `/WX-` as the source file and the
libmimalloc-sys build script fails on Windows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/chore A trivial change label Oct 26, 2026
@robert3005
robert3005 enabled auto-merge (squash) October 26, 2026 16:47
@codspeed

codspeed Bot commented Oct 26, 2026

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

4 warnings, 1 note

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ Unable to measure the execution of 2 benchmarks

These benchmarks measured no execution time, so their results are not comparable and count as unchanged. This usually happens when the compiler removes the code under test.

Prevent compiler optimizations

See affected benchmarks

⚠️ 20 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ Base and head ran on different runner types

Some benchmarks with significant performance changes were compared across different runner types, so the changes might not come from the code. Run base and head on the same runner type, or use CodSpeed Macro Runners for more stable results.

Learn more about Macro Runners

Open the report in CodSpeed to investigate

ℹ️ 40 benchmarks have no flamegraph

The flamegraph wasn't generated: the symbols of the profiling trace could not be resolved, because no information about the language frames was collected.

See affected benchmarks

⚡ 10 improved benchmarks
❌ 1 regressed benchmark
✅ 2428 untouched benchmarks
⏩ 12 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ CPU Simulation compare[1] 166.8 µs 188.4 µs -11.48%
⚡ Walltime filter_neon[8] 1,460 ns 884 ns +65.16%
⚡ Walltime threshold_neon[8] 1.8 µs 1.3 µs +31.64%
⚡ CPU Simulation compare[1] 132.8 µs 110.9 µs +19.74%
⚡ Walltime threshold_neon[64] 3 µs 2.5 µs +18.84%
⚡ Walltime filter_neon[64] 2.1 µs 1.8 µs +18.08%
⚡ Walltime threshold_neon[80] 4 µs 3.4 µs +17.53%
⚡ CPU Simulation test_repeated_scan_scalar_at[int_float] 426 µs 362.9 µs +17.39%
⚡ Walltime filter_neon[80] 2.9 µs 2.5 µs +17.13%
⚡ Walltime random_rotating_avx2[(0.5, 0.02, "self_50pct_mask_2pct")] 55.1 µs 49.5 µs +11.29%
⚡ CPU Simulation chunked_canonicalize_into[(20, 100, 16, 4)] 370.1 µs 336.3 µs +10.04%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/pin-cc-1.8 (6b6d260) with develop (c9101d3)

Open in CodSpeed

Footnotes

  1. 12 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@robert3005
robert3005 merged commit 4b453df into develop Oct 26, 2026
113 of 115 checks passed
@robert3005
robert3005 deleted the rk/pin-cc-1.8 branch October 26, 2026 16:58
joseph-isaacs pushed a commit that referenced this pull request Oct 26, 2026
Brings in the cc 1.8.0 pin that fixes the Windows CI build (#10815).

Signed-off-by: Claude <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01M8NsCJMx4C45Wf2Df24qzZ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants