Repository navigation
Pin cc to 1.8.0 to fix the Windows CI build - #10815
Conversation
cc 1.9 and later run cl.exe through RUSTC_WRAPPER (sccache). sccache 0.18 does not parse `-Tp <file>` and puts `/WX-` before the file in its preprocess command, so cl.exe reads `/WX-` as the source file and the libmimalloc-sys build script fails on Windows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Robert Kruszewski <github@robertk.io>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Robert Kruszewski <github@robertk.io>
Merging this PR will regress 1 benchmark4 warnings, 1 note
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
Brings in the cc 1.8.0 pin that fixes the Windows CI build (#10815). Signed-off-by: Claude <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M8NsCJMx4C45Wf2Df24qzZ
#10810 updated
ccfrom 1.8.0 to 1.10.0. After that,Rust tests (windows-x64)fails in thelibmimalloc-sysbuild script:Cause:
cc1.9.0,ccrunscl.exethrough theRUSTC_WRAPPERfallback. CI setsRUSTC_WRAPPER=sccache.cc1.8.0 runscl.exedirectly..ccsources,ccpasses-Tp <file>as two separate arguments. sccache 0.18.0 does not know-Tp, so it treats it as an unknown flag./WX-before the input file.cl.exethen reads/WX-as the-Tpsource file.