Skip to content

Update Cargo.lock to pick up security fixes - #10810

Merged
robert3005 merged 4 commits into
developfrom
rk/update-lockfile
Oct 26, 2026
Merged

robert3005 merged 4 commits into
developfrom
rk/update-lockfile

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

Summary

Regenerate the root Cargo.lock with cargo update to work around reported CVEs. Only the lockfile changes; no Cargo.toml changes.

Changes

  • 92 package versions move to their latest semver-compatible releases.
  • Notable bumps: arrow-*/parquet 58.4.0 → 58.4.1 and 59.3.1 → 59.3.2, AWS SDK and smithy crates, tokio 1.53.3 → 1.54.1, icu_* 2.3 → 2.4, zip 9.0.5 → 9.1.2, webpki-roots/webpki-root-certs 1.0.10 → 1.0.11, uuid, smallvec, cc, liblzma, lzma-rust2.
  • New transitive packages from the parquet patch releases: thrift 0.23.0, ordered-float 3.9.2. pin-utils is removed.
  • Updates that need a manifest change (for example arrow/parquet 60.0.0) are not included.

Checks

  • cargo metadata --locked: passes.
  • cargo audit / cargo deny check advisories: not run successfully. The local tool versions cannot parse CVSS 4.0 entries in the current advisory database. CI is the source of truth for the advisory check.
  • No local build, clippy or tests.

🤖 Generated with Claude Code

Run cargo update to move dependencies to their latest
semver-compatible releases and work around reported CVEs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/chore A trivial change label Oct 26, 2026
@connortsui20

Copy link
Copy Markdown
Member

i think github fell over

@connortsui20
connortsui20 enabled auto-merge (squash) October 26, 2026 15:46
@codspeed

codspeed Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 4.34%

4 warnings, 1 note

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ Unable to measure the execution of 2 benchmarks

These benchmarks measured no execution time, so their results are not comparable and count as unchanged. This usually happens when the compiler removes the code under test.

Prevent compiler optimizations

See affected benchmarks

⚠️ 19 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ Base and head ran on different runner types

Some benchmarks with significant performance changes were compared across different runner types, so the changes might not come from the code. Run base and head on the same runner type, or use CodSpeed Macro Runners for more stable results.

Learn more about Macro Runners

Open the report in CodSpeed to investigate

ℹ️ 40 benchmarks have no flamegraph

The flamegraph wasn't generated: the symbols of the profiling trace could not be resolved, because no information about the language frames was collected.

See affected benchmarks

⚡ 2 improved benchmarks
❌ 3 regressed benchmarks
✅ 2403 untouched benchmarks
⏩ 12 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ CPU Simulation test_repeated_scan_scalar_at[int_float] 362.9 µs 432.5 µs -16.09%
❌ Walltime bitpack_blocked_compress_avx512 4.8 µs 5.6 µs -13.53%
❌ Walltime random_rotating_avx2[(0.5, 0.02, "self_50pct_mask_2pct")] 48.4 µs 54.7 µs -11.55%
⚡ CPU Simulation test_scan_filter[int] 3.4 ms 3 ms +13.11%
⚡ Walltime words_gather_dispatch_neon[65536] 2 µs 1.8 µs +10.33%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/update-lockfile (19b333f) with develop (b325ef9)

Open in CodSpeed

Footnotes

  1. 12 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Move the workspace zstd dependency from 0.13 to 0.14 to pick up
the security fix. Arrow, parquet, DataFusion and Lance still pin
zstd 0.13, so the lockfile keeps both versions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005
robert3005 disabled auto-merge October 26, 2026 15:55
robert3005 and others added 2 commits October 26, 2026 15:56
Ignore RUSTSEC-2026-0398 and RUSTSEC-2026-0403. Both affect
zstd-safe 7, which arrow, parquet, DataFusion and Lance still pull
in through zstd 0.13. We cannot upgrade it ourselves.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Ignore RUSTSEC-2026-0391. It affects zstd 0.13, which arrow,
parquet, DataFusion and Lance still pull in. We cannot upgrade it
ourselves.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005
robert3005 merged commit afa4bc8 into develop Oct 26, 2026
84 of 86 checks passed
@robert3005
robert3005 deleted the rk/update-lockfile branch October 26, 2026 16:23
joseph-isaacs pushed a commit that referenced this pull request Oct 26, 2026
Brings in the Cargo.lock update and zstd advisory ignores (#10810).

Signed-off-by: Claude <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01M8NsCJMx4C45Wf2Df24qzZ
robert3005 added a commit that referenced this pull request Oct 26, 2026
#10810 updated `cc` from 1.8.0 to 1.10.0. After that, `Rust tests
(windows-x64)` fails in the `libmimalloc-sys` build script:

```text
c1xx: fatal error C1083: Cannot open source file: '/WX-': No such file or directory
error: failed to run custom build command for `libmimalloc-sys v0.1.49`
```

Cause:

1. Starting with `cc` 1.9.0, `cc` runs `cl.exe` through the
`RUSTC_WRAPPER` fallback. CI sets `RUSTC_WRAPPER=sccache`. `cc` 1.8.0
runs `cl.exe` directly.
2. For `.cc` sources, `cc` passes `-Tp <file>` as two separate
arguments. sccache 0.18.0 does not know `-Tp`, so it treats it as an
unknown flag.
3. The sccache preprocess command adds `/WX-` before the input file.
`cl.exe` then reads `/WX-` as the `-Tp` source file.

---------

Signed-off-by: Robert Kruszewski <github@robertk.io>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants