Skip to content

Fix semantic conflict in c++ tests - #10638

Merged
robert3005 merged 1 commit into
developfrom
rk/linters
Oct 20, 2026
Merged

robert3005 merged 1 commit into
developfrom
rk/linters

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/skip Do not list PR in the changelog label Oct 20, 2026
@robert3005
robert3005 enabled auto-merge (squash) October 20, 2026 12:44
robert3005 pushed a commit that referenced this pull request Oct 20, 2026
The C++ field accessor no longer takes a session (#10611).
Same change as #10638.

Signed-off-by: Claude <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Y1zHpE1K1Y9HvyU4kt24Tq
@codspeed

codspeed Bot commented Oct 20, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 23.41%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ 22 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

ℹ️ 40 benchmarks have no flame graph

The flamegraph could not be generated because we failed to resolve the symbols in the profiling trace. This happens when we fail to harvest information about language frames.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
❌ 9 regressed benchmarks
✅ 2395 untouched benchmarks
⏩ 12 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation bench_compare_sliced_dict_primitive[(2000, 10000)] 13.9 µs 69.1 µs -79.88%
❌ WallTime threshold_neon[8] 1.4 µs 2.7 µs -48.84%
❌ Simulation density_sweep_dense_runs[0.001] 44.2 µs 62.2 µs -28.91%
❌ WallTime threshold_neon[64] 2.6 µs 3.6 µs -27.13%
❌ WallTime threshold_neon[80] 3.6 µs 4.7 µs -23.69%
❌ WallTime filter_neon[64] 1.8 µs 2.2 µs -19.91%
❌ WallTime filter_neon[80] 2.5 µs 3.1 µs -19.6%
❌ WallTime filter_neon[8] 921 ns 1,101 ns -16.35%
❌ WallTime words_gather_dispatch_neon[65536] 1.8 µs 2 µs -10.05%
⚡ ⚠️ Simulation test_scan_filter_to_arrow_array[int_float] 4.1 ms 3.5 ms +14.75%
⚡ ℹ️ Simulation test_repeated_scan_filter[int_float] 3.9 ms 3.4 ms +11.81%
⚡ ℹ️ Simulation test_repeated_scan_filter[int] 2.7 ms 2.4 ms +11.22%
⚡ ℹ️ Simulation test_scan_filter_to_arrow_array[int] 2.8 ms 2.5 ms +10.9%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/linters (ecc366c) with develop (7216cb5)

Open in CodSpeed

Footnotes

  1. 12 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@robert3005
robert3005 merged commit e717fab into develop Oct 20, 2026
113 of 115 checks passed
@robert3005
robert3005 deleted the rk/linters branch October 20, 2026 12:53
yiquanzhou added a commit to yiquanzhou/vortex that referenced this pull request Oct 20, 2026
…t-pushdown

* upstream/develop:
  Prune in_list expressions (vortex-data#10617)
  Fix semantic conflict in c++ tests (vortex-data#10638)

Signed-off-by: Yiquan Zhou <yiquan.zhou@dash0.com>

# Conflicts:
#	vortex-datafusion/src/convert/exprs/tests.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/skip Do not list PR in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants