Repository navigation
C++ FFI field access method doesn't require a session - #10611
Conversation
Signed-off-by: Robert Kruszewski <github@robertk.io>
Merging this PR will degrade performance by 9.14%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | WallTime | filter_neon[64] |
1.8 µs | 2.3 µs | -23.88% |
| ❌ | WallTime | filter_neon[8] |
1.4 µs | 1.8 µs | -22.05% |
| ❌ | Simulation | chunked_opt_bool_canonical_into[(1000, 10)] |
54.9 µs | 64.9 µs | -15.4% |
| ❌ |
Simulation | random_i128[0.01] |
5.5 µs | 6.3 µs | -12.63% |
| ⚡ | WallTime | threshold_neon[8] |
2.5 µs | 2.2 µs | +13.97% |
| ⚡ | Simulation | isolated_runs[u32, (16, 0)] |
89.5 µs | 79.5 µs | +12.6% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing rk/ffidowncast (11ab04c) with develop (d907f6e)2
Footnotes
-
12 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
develop(90c6f29) during the generation of this report, so d907f6e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
The C++ field accessor no longer takes a session (#10611). Same change as #10638. Signed-off-by: Claude <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y1zHpE1K1Y9HvyU4kt24Tq
Instead of requiring a session and executing we downcast leaving execution to
the caller if necessary