Skip to content

C++ FFI field access method doesn't require a session - #10611

Merged
robert3005 merged 1 commit into
developfrom
rk/ffidowncast
Oct 19, 2026
Merged

robert3005 merged 1 commit into
developfrom
rk/ffidowncast

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

Instead of requiring a session and executing we downcast leaving execution to
the caller if necessary

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005
robert3005 requested a review from myrrc October 19, 2026 12:42
@robert3005 robert3005 added the changelog/break A breaking API change label Oct 19, 2026
@robert3005
robert3005 enabled auto-merge (squash) October 19, 2026 12:43
@codspeed

codspeed Bot commented Oct 19, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 9.14%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ 1 benchmark measured no execution time

Nothing ran under measurement, usually because the compiler removed the code under test. This result is not comparable, so it counts as unchanged.

Preventing compiler optimizations

⚠️ 17 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

ℹ️ 40 benchmarks have no flame graph

The flamegraph could not be generated because we failed to resolve the symbols in the profiling trace. This happens when we fail to harvest information about language frames.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
❌ 4 regressed benchmarks
✅ 2402 untouched benchmarks
⏩ 12 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ WallTime filter_neon[64] 1.8 µs 2.3 µs -23.88%
❌ WallTime filter_neon[8] 1.4 µs 1.8 µs -22.05%
❌ Simulation chunked_opt_bool_canonical_into[(1000, 10)] 54.9 µs 64.9 µs -15.4%
❌ ⚠️ Simulation random_i128[0.01] 5.5 µs 6.3 µs -12.63%
⚡ WallTime threshold_neon[8] 2.5 µs 2.2 µs +13.97%
⚡ Simulation isolated_runs[u32, (16, 0)] 89.5 µs 79.5 µs +12.6%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/ffidowncast (11ab04c) with develop (d907f6e)2

Open in CodSpeed

Footnotes

  1. 12 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on develop (90c6f29) during the generation of this report, so d907f6e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@myrrc myrrc added lang/cpp Relates to the Vortex C++ API lang/c Relates to the Vortex C (FFI) API labels Oct 19, 2026
@robert3005
robert3005 merged commit 07fe4c5 into develop Oct 19, 2026
167 of 170 checks passed
@robert3005
robert3005 deleted the rk/ffidowncast branch October 19, 2026 13:26
robert3005 pushed a commit that referenced this pull request Oct 20, 2026
The C++ field accessor no longer takes a session (#10611).
Same change as #10638.

Signed-off-by: Claude <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Y1zHpE1K1Y9HvyU4kt24Tq
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change lang/c Relates to the Vortex C (FFI) API lang/cpp Relates to the Vortex C++ API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants