Skip to content

Test: robust timing in the region signal-handler test #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
b-re-w merged 1 commit into from
Oct 25, 2026
Merged

Test: robust timing in the region signal-handler test #334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions python-multiplatform-ksp/src/test/python/test_regions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,15 +613,16 @@ def test_a_class_change_by_a_signal_handler_in_the_consumer_deopts_the_region_ho
so = cbuild.build(text, "regsig", tmp_path / "out", runtime_dir=runtime_dir())
m = cbuild.load("regsig", so)
d = 21
t0 = time.perf_counter()
assert m.tree_sum(d) == nodes(d)
delay = 0.85 * (time.perf_counter() - t0)
caught = False
for k in range(5): # under load the timer can land after the call; then try again
for k in range(12): # under load the timer can land after the call; then try again
# Re-measured before every attempt: on a shared CI runner one baseline does not predict the
# next call's length, so a single measurement put every timer after the call (#331 run).
t0 = time.perf_counter()
assert m.tree_sum(d) == nodes(d)
delay = (0.85, 0.8, 0.75, 0.7)[k % 4] * (time.perf_counter() - t0)
d0 = m.__typedpython_deopts__
o0, f0, _ = m.__typedpython_region_stats__()
got = _with_property_installed_by_handler(lambda: m.tree_sum(d), m.Node,
delay * (0.85, 0.8, 0.9, 0.75, 0.7)[k] / 0.85)
got = _with_property_installed_by_handler(lambda: m.tree_sum(d), m.Node, delay)
o1, f1, _ = m.__typedpython_region_stats__()
assert o1 - o0 == f1 - f0
if m.__typedpython_deopts__ > d0: # the host noticed and redid the call
Expand Down