Repository navigation
Test: robust timing in the region signal-handler test - #334
Merged
Merged
Conversation
…attempt On the macOS CI runner one baseline measurement did not predict the next call's length, so every timer landed after the call and the test failed without any defect. Each of up to 12 attempts now measures first. A mutant without the region field-read guard still fails it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TypedPython CI macOS job failed on the #331 merge commit only in test_regions.py::test_a_class_change_by_a_signal_handler_in_the_consumer_deopts_the_region_host ('the handler never landed inside the call'). There was no defect: the timer was set from one baseline, and the shared runner's next calls were longer. The test now re-measures the call before each of up to 12 attempts (at 0.85/0.8/0.75/0.7 of it).
Evidence:
The rest of TypedPython CI on 4acf7fb: Linux plain and ASan+UBSan are green (the vd fix from #331), and the app fixture job is green.