This repository was archived by the owner on Jan 17, 2019. It is now read-only.
Repository navigation
rmbox: change binary names of logger and rmbox - #105
Merged
Merged
Conversation
Collaborator
|
@bkokoszx , would you please add a brief description in the PR and commit message? This will help others to understand your major change/purpose before reading the code. |
This was referenced Oct 13, 2018
bkokoszx
force-pushed
the
sof-logger
branch
2 times, most recently
from
October 15, 2018 08:54
12ee8f3 to
f6ffd1e
Compare
Contributor
Author
|
@mengdonglin I've updated commit and PR messages. |
lgirdwood
suggested changes
Oct 15, 2018
| @@ -1,12 +1,12 @@ | |||
| bin_PROGRAMS = rmbox logger | |||
| bin_PROGRAMS = rmbox sof_logger | |||
Member
There was a problem hiding this comment.
convention is to use - instead of _ for naming. So it would be "sof-logger". rmbox should follow same convention too ("sof-mbox").
Contributor
Author
There was a problem hiding this comment.
@lgirdwood I've updated this. I've also changed file name in macro in rmbox.c.
bkokoszx
changed the title
Change binary names: from logger to sof-logger and from rmbox to sof-rmbox Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change binary names:
Signed-off-by: Bartosz Kokoszko bartoszx.kokoszko@linux.intel.com