Skip to content
This repository was archived by the owner on Jan 17, 2019. It is now read-only.
This repository was archived by the owner on Jan 17, 2019. It is now read-only.

Logger does not show timestamps as time #94

Closed

Description

@singalsu

The old rmbox printed handy timestamps with seconds as measure unit. It was easy to see e.g. how long the copy() operation for a component took in microseconds and convert that to a (coarse) MCPS value. The new logger shows timestamp only as a counter value. Could this be changed back to time?

It also would help a lot to compare side by side kernel dmesg and firmware logs.

Activity

  1. added
    bugSomething isn't working
    enhancementNew feature or request
    P2Critical bugs or normal features
    and removed
    bugSomething isn't working
    on Oct 11, 2018
  2. akloniex commented on Oct 11, 2018

    @akloniex
    Member

    @singalsu @mengdonglin
    Feature was implemented during unification of rmbox and logger tools: #88 merged 3 days ago.
    -c parameter allows to specify clock rate, with default 19.2, similarly as rmbox did.

    Please check current version.

  3. singalsu commented on Oct 11, 2018

    @singalsu
    CollaboratorAuthor

    That sounds excellent, I'll test it and close this. I'm anyways using a script due to more command line parameters required for typical usage so it's easy to add the -c for clock rate there.

  4. mengdonglin commented on Oct 11, 2018

    @mengdonglin
    Collaborator

    @akloniex Could you help to submit a PR for a README, as a user guide for the new logger?
    Or could you guide us to the document if it's ready there? Thanks

  5. cujomalainey commented on Oct 11, 2018

    @cujomalainey
    Contributor

    Please make sure this documentation is available publically.

  6. mengdonglin commented on Oct 12, 2018

    @mengdonglin
    Collaborator

    @singalsu, does it work on your side? If yes, please close this issue.
    @akloniex I created a new issue #102 for the document, could you help on that? Thanks!

  7. singalsu commented on Oct 12, 2018

    @singalsu
    CollaboratorAuthor

    @akloniex OK, now when I use executable /usr/local/bin/logger it works and shows with -c 19.2 the time as expected.

    However why was the name changed back to logger? I have also on my computer /usr/bin/logger from Ubuntu package bsdutils for totally different purpose. I'll close this anyway since the executable name is another discussion.

  8. singalsu commented on Oct 12, 2018

    @singalsu
    CollaboratorAuthor

    Closing

  9. mengdonglin commented on Oct 14, 2018

    @mengdonglin
    Collaborator

    @singalsu I saw PR #105 is renaming the new logger name from logger to sof_logger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Critical bugs or normal featuresenhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions