Repository navigation
[SKIP SOF-TEST] fuzz.sh: add new boards/native_sim_libfuzzer.conf - #9389
Merged
Merged
Conversation
Extract -DCONFIG_* definitions hardcoded inside the script and move them to a new .conf file where they belong. This is a first, baby-step towards addressing the more general lack of .config control described in thesofproject#9386 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Collaborator
Author
|
The failures are unrelated, caused by #9365 which was merged broken. This PR affects fuzzing only, all other errors are unrelated. |
marc-hb
marked this pull request as ready for review
August 22, 2024 04:05
marc-hb
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
August 22, 2024 04:05
lgirdwood
approved these changes
Aug 22, 2024
| -DCONFIG_ASAN=y | ||
| ) | ||
| # https://docs.zephyrproject.org/latest/build/kconfig/setting.html#initial-conf | ||
| local conf_files_list='prj.conf;boards/native_sim_libfuzzer.conf' |
Contributor
There was a problem hiding this comment.
can we make it so we can append to this list. I.e. the ASAN config would be split so we can use the base config with other sanitzer configs.
Collaborator
Author
There was a problem hiding this comment.
Yes that's the idea. In some future PR(s) anyone can just go and (for instance) do:
if $something; then
conf_files_list+=';debug.conf'
cujomalainey
approved these changes
Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract -DCONFIG_* definitions hardcoded inside the script and move them to a new .conf file where they belong.
This is a first, baby-step towards addressing the more general lack of .config control described in #9386