Repository navigation
scripts: add debug build to fuzz.sh - #9375
cujomalainey wants to merge 1 commit into
Conversation
Add flag for adding symbols in easily. Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
| -j n Number of concurrent -jobs=n. Defaults to 1. | ||
| The value 0 uses the output of the 'nproc' command. | ||
| -d Add debug optimizations and symbols to the build. | ||
| Useful for testcase reproduction. |
There was a problem hiding this comment.
Why not add these CONFIG_DEBUG* always? Are they slowing anything down?
There was a problem hiding this comment.
That was my thought that it would reduce the exec/s of the fuzzer. The build already has enough to get a stack trace so I didnt think it needed anymore since the automated tools don't do anything more.
Done, submitted #9389. This moves all CONFIG_ values to .conf files which will help re-use and reduce duplicate/diverge. Based on it, could this new -d option include the already existing app/debug_overlay.conf file? |
That will be helpful also for enabling multiple sanitizers again. Much appreciated. |
| -DCONFIG_ASAN=y | ||
| ) | ||
|
|
||
| local debug_configs=( |
There was a problem hiding this comment.
It's pretty amazing that this does NOT git conflict considering I removed the entire fuzz_configs variable above (and more) in merged commit 577c9ae and replaced it with local conf_files_list=... which looks entirely different! Yet neither git cherry-pick nor git merge seem to bother - wow!
Even if not a git conflict, this is still very much a logical conflict so this PR should not be merged as is right now.
There will likely be another conflict with incoming #9409, so maybe wait for that to be merged too.
|
@cujomalainey still needed ? |
Yes but in a different form. We have symbols already. They just only work with lldb. I need to add a flag to switch to -Og from -O2. |
|
Closing as I think this isn't needed anymore |
Add flag for adding symbols in easily.