Repository navigation
scripts: pre update sof docker for cmake covert - #852
Merged
Merged
Conversation
Update the sof docker to support cmake to pre test cmake build system change. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
xiulipan
requested review from
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
January 16, 2019 10:45
jajanusz
approved these changes
Jan 21, 2019
jajanusz
left a comment
jajanusz
left a comment
Contributor
There was a problem hiding this comment.
I guess it's needed for this CI: http://otc-sof-ci.sh.intel.com:8080/job/sof_prs/536/consoleText
If so we need to merge it asap so it has CMake.
@xiulipan Am I right?
Member
Contributor
Contributor
Author
|
@jajanusz @lgirdwood |
Contributor
Author
|
@lgirdwood Please merge this PR as I have already update the docker image with the scripts in this PR. And it works fine with both old build system and new system |
xiulipan
changed the title
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the sof docker to support cmake to pre test cmake build system
change.
Signed-off-by: Pan Xiuli xiuli.pan@linux.intel.com
pre test for #845