Repository navigation
Tools: Topology2: Remove bytes control from cavs-nocodec-rtcaec.conf - #8453
Merged
kv2019i merged 1 commit intoNov 9, 2023
Merged
Conversation
It was confirmed that the IPC4 version of Google RTC AEC is not using the bytes control, so it can be safely removed from topology. This fixes topologies build error: ALSA lib conf.c:838:(get_char_skip_comments) Cannot access file include/components/google-rtc-aec/rtc-aec-blob.conf Fixes: 64fcebb ("Tools: Topology2: Add nocodec topology to test google-rtc-aec") Fixes: thesofproject#8357 Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
ranj063
approved these changes
Nov 6, 2023
btian1
approved these changes
Nov 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was confirmed that the IPC4 version of Google RTC AEC is not using the bytes control, so it can be safely removed from topology.
This fixes topologies build error:
ALSA lib conf.c:838:(get_char_skip_comments)
Cannot access file include/components/google-rtc-aec/rtc-aec-blob.conf
Fixes: 64fcebb
("Tools: Topology2: Add nocodec topology to test google-rtc-aec")
Fixes: #8357