Repository navigation
[BUG] topology2/rtc-aec: missing include file #8357
Description
Describe the bug
error in topology build ....
To Reproduce
./sof/scripts/docker-run.sh ./scripts/build-tools.sh
Reproduction Rate
100%
Expected behavior
no warnings on topology
Impact
annoyance or showstopper, who knows what is generated
Environment
* SOF: 054003f
Screenshots or console output
[584/601] Generating sof-tgl-nocodec-rtcaec.tplg
ALSA lib conf.c:838:(get_char_skip_comments) Cannot access file include/components/google-rtc-aec/rtc-aec-blob.conf
saving nhlt as binary in nhlt-sof-tgl-nocodec-rtcaec.bin
Activity
plbossart commentedon Oct 19, 2023
@singalsu @ranj063 fyi
singalsu commentedon Oct 20, 2023
Seems I have missed to include this blob conversion from tplg1 to 64fcebb. Thanks for reporting @plbossart !
singalsu commentedon Oct 20, 2023
Actually it seems that commit 9e9120a removed the file.
But I think it's a mistake, the blob should be duplicated from tplg1 to tplg2:
https://github.com/thesofproject/sof/blob/main/tools/topology/topology1/m4/google_rtc_audio_processing_default.m4
Tools: Topology2: Google RTC AEC: Copy default blob from topology1
marc-hb commentedon Oct 20, 2023
Why is this error not fatal? As of version 1.2.10,
alsatplgreturns success status0and generates a topology file anyway!Much more than an SOF bug, this looks like a serious
alsatplginclude bug. Who knows what other includes are missing in other files and what content gets generated. I know error handling is rarely ever tested and that C does not care about errors but this seems to go a bit too far.plbossart commentedon Oct 20, 2023
@ranj063 any comments?
ranj063 commentedon Nov 6, 2023
@singalsu thats not correct. The blob was needed for IPC3 to set the audio format for the reference. But with IPC4 we send all audio formats with the init module instance IPC. So, no it wasnt a mistake. It is the right thing to do
singalsu commentedon Nov 6, 2023
Thanks, I'll do another fix, just not reference the missing blob in test topology.
Tools: Topology2: Remove bytes control from cavs-nocodec-rtcaec.conf
Tools: Topology2: Remove bytes control from cavs-nocodec-rtcaec.conf
marc-hb commentedon Nov 10, 2023
Ping?
singalsu commentedon Feb 8, 2024
This was fixed by #8453.