Repository navigation
Change the naming scheme for the SSP/HDA/DMIC DAI copiers - #7670
Conversation
There was a problem hiding this comment.
Why didn't we need direction before?
There was a problem hiding this comment.
its never used before. direction is only meant for IPC3. But now I need it for the name
There was a problem hiding this comment.
if we need to reduce the widget name length, "playback" and "capture" are obvious targets.
We could use something like "p"/"c" (as done for ALSA in /proc pcm0c/ pcm0p/ pcm10p/ pcm1p/). Or 'pb' and 'cp'.
Just a suggestion.
|
SOFCI TEST |
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
The dependency to kernel change is unfortunate, but I guess a price we have to pay. Otherwise, this is a massive improvement to readability/maintainability of the tplg files, so a very welcome change.
There was a problem hiding this comment.
"These are" or "They are"
There was a problem hiding this comment.
fixed and now the kernel dependency is merged as well. So lets retest
To make it explicit that it is only for the DAI gateway. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Move the uuid attribute definition to widget-common. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
In preparation for changing the name of the DAI copier which will make them a bit longer, reduce the token name lengths by removing the sof_tkn_ prefix. This is required because the header names in topology have a 44 character limit and with a long name like: dai-copier.SSP.NoCodec-0.playback.sof_tkn_comp.uuid, the limit will be hit. Removing the sof_tkn_ prefix will reduce the number of characters in the tuple name headers. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Change the naming from dai-copier.<copier_type>.<pipeline_id>.<instance> to dai_copier.<copier_type>.<stream_name.<direction>. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
…ndatory Set them based on direction and the actual number of pins used. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
These are mandatory for both directions as they are used to set the DMA buffer format. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
|
Nothing related to this PR in https://sof-ci.01.org/sofpr/PR7670/build8583/devicetest/index.html , proceeding with merge. |
Change the convention from
copier.<copier_type>.<pipeline ID>.<instance ID>to
dai-copier.<copier_type>.<stream_name>.<direction>Depends on thesofproject/linux#4375