Repository navigation
ASoC: topology: Allow partial matching when finding DAI link - #4375
Merged
plbossart merged 1 commit intoMay 25, 2023
Merged
Conversation
ranj063
requested review from
ajitkupandey,
bardliao,
dbaluta,
kuanhsuncheng,
kv2019i,
lgirdwood,
plbossart,
ujfalusi and
yaochunhung
as code owners
May 24, 2023 19:02
plbossart
previously approved these changes
May 24, 2023
bardliao
previously approved these changes
May 25, 2023
btian1
reviewed
May 25, 2023
ranj063
force-pushed
the
fix/dai_link_connect
branch
from
May 25, 2023 13:20
7e1ca10 to
07a3e0f
Compare
This allows for setting shorter link names in topology. For example, for the HDA Analog DAI link, just "Analog" would suffice instead of "Analog Playback and Capture" Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
ranj063
force-pushed
the
fix/dai_link_connect
branch
from
May 25, 2023 13:22
07a3e0f to
96fd04c
Compare
bardliao
approved these changes
May 25, 2023
ujfalusi
approved these changes
May 25, 2023
ujfalusi
left a comment
ujfalusi
left a comment
Collaborator
There was a problem hiding this comment.
It will not cause regression for existing topologies (SOF or not SOF), I'm not sure if it is going to be better on the tplg side as previously we could grep for "Analog Playback and Capture" and find the relevant section. If it is reduced to just "Analog", it is going to be a tad harder to find the same place...
Collaborator
Author
|
SOFCI TEST |
1 similar comment
Collaborator
Author
|
SOFCI TEST |
plbossart
approved these changes
May 25, 2023
Collaborator
|
SOFCI TEST |
Collaborator
|
I aborted main-cavs test, that's why it has weird status.
I re-run the test manually, it looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for setting shorter stream_names in topology. For example, for the HDA Analog DAI link, just "Analog" would suffice instead of "Analog Playback and Capture"