Repository navigation
schedule: zephyr_dma_domain: Conditionally call interrupt_clear_mask() - #7470
Merged
lgirdwood merged 1 commit intoApr 24, 2023
Merged
Conversation
This was referenced Apr 19, 2023
LaurentiuM1234
marked this pull request as ready for review
April 19, 2023 14:27
LaurentiuM1234
requested review from
marcinszkudlinski and
pblaszko
as code owners
April 19, 2023 14:27
paulstelian97
approved these changes
Apr 19, 2023
dbaluta
approved these changes
Apr 20, 2023
…ARM64 In the case of ARM64 with GIC, the interrupts are cleared after the ISR is executed (for reference please see arm_gic_eoi() and arch/arm64/core/isr_wrapper.S from Zephyr). Thanks to this, we don't need to clear them explicitly, hence there's no need for interrupt_clear_mask() to be defined. This commit fixes linkage problems caused by the fact that interrupt_clear_mask() is not defined on ARM64. Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
Contributor
Author
|
Removed the need to use the ifdefs by adding a macro for |
paulstelian97
approved these changes
Apr 21, 2023
paulstelian97
left a comment
paulstelian97
left a comment
Collaborator
There was a problem hiding this comment.
Re-approve, this is much better than the version I previously approved. Good work!
dbaluta
approved these changes
Apr 21, 2023
kv2019i
approved these changes
Apr 24, 2023
Collaborator
|
Feel free to merge, I'll give @iuliana-prodan to re-review as well. |
lgirdwood
approved these changes
Apr 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no need to clear IRQ mask on ARM64 architecture as there's currently no way to mask them. This commit aims to fix the compilation issues that would be caused by calling interrupt_clear_mask() on ARM64-based platforms.